You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "gangliao (via GitHub)" <gi...@apache.org> on 2023/03/13 04:53:53 UTC
[GitHub] [kudu] gangliao opened a new pull request, #51: fix: set the result block to the decompressed data
gangliao opened a new pull request, #51:
URL: https://github.com/apache/kudu/pull/51
I mean, this is a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kudu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kudu] gangliao commented on a diff in pull request #51: fix: set the result block to the decompressed data
Posted by "gangliao (via GitHub)" <gi...@apache.org>.
gangliao commented on code in PR #51:
URL: https://github.com/apache/kudu/pull/51#discussion_r1133448252
##########
src/kudu/cfile/cfile_reader.cc:
##########
@@ -546,7 +546,7 @@ Status CFileReader::ReadBlock(const IOContext* io_context,
scratch.Swap(&decompressed_scratch);
// Set the result block to our decompressed data.
- block = Slice(buf, uncompressed_size);
+ block = scratch.as_slice();
Review Comment:
```
buf = scratch.get();
block = scratch.as_slice();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kudu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kudu] acelyc111 commented on pull request #51: fix: set the result block to the decompressed data
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on PR #51:
URL: https://github.com/apache/kudu/pull/51#issuecomment-1465537459
Hi @gangliao,
Thank you for the pull request. The Kudu project doesn't merge new code through GitHub PRs; we use the [gerrit](https://gerrit.cloudera.org/q/status:open%20project:kudu) tool to do code review and submission. Could you please follow the directions [here](https://kudu.apache.org/docs/contributing.html) to adapt this PR into a gerrit change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kudu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org