You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2013/11/04 16:27:20 UTC
[jira] [Commented] (CODEC-174) Improve performance of Beider Morse
encoder
[ https://issues.apache.org/jira/browse/CODEC-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812902#comment-13812902 ]
Gary Gregory commented on CODEC-174:
------------------------------------
Hi Thomas,
Thank you for your contribution.
A couple of comments:
- Make sure you provide patch on top of trunk.
- Make sure the test coverage does not get worse.
- A test program we can run before and after your patches would help confirm that the performance is in fact better.
Thank you,
Gary
> Improve performance of Beider Morse encoder
> -------------------------------------------
>
> Key: CODEC-174
> URL: https://issues.apache.org/jira/browse/CODEC-174
> Project: Commons Codec
> Issue Type: Improvement
> Affects Versions: 1.6, 1.7
> Reporter: Thomas Champagne
> Labels: patch, performance
> Attachments: CODEC-174-change-rules-storage-to-Map.patch, CODEC-174-delete-subsequence-cache.patch
>
>
> I use Beider Morse encoder with Solr. When it indexes a lot of documents using this encoder, the import time is multiplied by 30. So, I have decided to optimize the current implementation in the commons-codec.
> Currently, I have created two patch. The first patch delete a "performance hack" about a subsequence cache. This cache doesn't optimize performance and after deleting it, you can win some milliseconds.
> The second patch changes the storage of the rules in memory using a Map instead of List. With it, you can access to a rule directly with the beginning of pattern. This patch divide the encoding time by 2.
> I will try to find more improvement. If you have any idea, please tell me it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)