You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/11/17 12:46:55 UTC
[GitHub] [avro] RyanSkraba opened a new pull request #987: AVRO-2702: Fix and test UNION equivalents.
RyanSkraba opened a new pull request #987:
URL: https://github.com/apache/avro/pull/987
This PR adds a commit for unit testing the fix from https://github.com/apache/avro/pull/980
This shouldn't be squashed, credit to @bellemare
This is also built on top of the PHP fix from https://github.com/apache/avro/pull/986
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-2702
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] iemejia merged pull request #987: AVRO-2702: Fix and test UNION equivalents.
Posted by GitBox <gi...@apache.org>.
iemejia merged pull request #987:
URL: https://github.com/apache/avro/pull/987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #987: AVRO-2702: Fix and test UNION equivalents.
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #987:
URL: https://github.com/apache/avro/pull/987#issuecomment-728945911
All three commits cherry-picked to [branch-1.10](https://github.com/apache/avro/commit/8755f9f7c085391a4e1079d792d5934799039f0d)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] bellemare commented on pull request #987: AVRO-2702: Fix and test UNION equivalents.
Posted by GitBox <gi...@apache.org>.
bellemare commented on pull request #987:
URL: https://github.com/apache/avro/pull/987#issuecomment-729004450
@RyanSkraba Thanks Ryan! I appreciate you doing the all the hard parts! :) Credit to YOU!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org