You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/12 05:09:31 UTC

[GitHub] [flink] swhelan091 opened a new pull request #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only

swhelan091 opened a new pull request #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only
URL: https://github.com/apache/flink/pull/11066
 
 
     ## What is the purpose of the change
   
   This pull request improves the RegistryAvroSerializationSchema class such that it will only attempt to register the schema with the Schema Registry on the first message. All subsequent messages will retrieve the schema id from the cache. 
   
   ## Brief change log
   
   *(for example:)*
     - Update RegistryAvroSerializationSchema to utilize the same instance of SchemaCoder for each message so it can retrieve the schema id from the cache after initial registration.
   
   ## Verifying this change
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (don't know)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys merged pull request #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only

Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only
URL: https://github.com/apache/flink/pull/11066
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dawidwys commented on issue #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only

Posted by GitBox <gi...@apache.org>.
dawidwys commented on issue #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only
URL: https://github.com/apache/flink/pull/11066#issuecomment-585075220
 
 
   Thank you @swhelan091 for your contribution. Merged it into the master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only
URL: https://github.com/apache/flink/pull/11066#issuecomment-585041196
 
 
   <!--
   Meta data
   Hash:42576e72b45fb023ced6d80819d919ba6110c00c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148521513 TriggerType:PUSH TriggerID:42576e72b45fb023ced6d80819d919ba6110c00c
   Hash:42576e72b45fb023ced6d80819d919ba6110c00c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5086 TriggerType:PUSH TriggerID:42576e72b45fb023ced6d80819d919ba6110c00c
   -->
   ## CI report:
   
   * 42576e72b45fb023ced6d80819d919ba6110c00c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148521513) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5086) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only
URL: https://github.com/apache/flink/pull/11066#issuecomment-585041196
 
 
   <!--
   Meta data
   Hash:42576e72b45fb023ced6d80819d919ba6110c00c Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148521513 TriggerType:PUSH TriggerID:42576e72b45fb023ced6d80819d919ba6110c00c
   Hash:42576e72b45fb023ced6d80819d919ba6110c00c Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5086 TriggerType:PUSH TriggerID:42576e72b45fb023ced6d80819d919ba6110c00c
   -->
   ## CI report:
   
   * 42576e72b45fb023ced6d80819d919ba6110c00c Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148521513) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5086) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only
URL: https://github.com/apache/flink/pull/11066#issuecomment-585033022
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 42576e72b45fb023ced6d80819d919ba6110c00c (Wed Feb 12 05:12:14 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11066: [FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only
URL: https://github.com/apache/flink/pull/11066#issuecomment-585041196
 
 
   <!--
   Meta data
   Hash:42576e72b45fb023ced6d80819d919ba6110c00c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:42576e72b45fb023ced6d80819d919ba6110c00c
   -->
   ## CI report:
   
   * 42576e72b45fb023ced6d80819d919ba6110c00c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services