You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrey Pavlenko (JIRA)" <ji...@apache.org> on 2007/04/04 09:56:32 UTC
[jira] Created: (HARMONY-3570) [classlib][awt] Png decoder does not
work on Linux x86_64
[classlib][awt] Png decoder does not work on Linux x86_64
---------------------------------------------------------
Key: HARMONY-3570
URL: https://issues.apache.org/jira/browse/HARMONY-3570
Project: Harmony
Issue Type: Bug
Reporter: Andrey Pavlenko
The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
Test output:
Fjava.lang.RuntimeException: Invalid image width
at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
java.lang.RuntimeException: Invalid image width
at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
Time: 8.183
There was 1 failure:
1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3570) [classlib][awt] Png decoder does not
work on Linux x86_64
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Pavlenko updated HARMONY-3570:
-------------------------------------
Attachment: HARMONY-3570.patch
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3570) [classlib][awt] Png decoder does
not work on Linux x86_64
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488922 ]
Alexey Petrenko commented on HARMONY-3570:
------------------------------------------
I got one more concern about this patch after the small investigation.
Andrey, Alexei,
you've changed the type of width and height fields from int to unsigned long (png_uint_32) in native code. But this native fields has the direct representation in Java code: imageWidth and imageHeight fields of org.apache.harmony.awt.gl.image.PngDecoder class. And these fields are of type int.
Guys, are your sure that this is ok to change the type in native code and leave the type unchanged in Java code?
I have no idea here since no evaluation for the patch has been provided.
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3570) [classlib][awt] Png decoder does not
work on Linux x86_64
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Pavlenko updated HARMONY-3570:
-------------------------------------
Attachment: (was: HARMONY-3570.patch)
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HARMONY-3570) [classlib][awt] Png decoder does
not work on Linux x86_64
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Beyer reopened HARMONY-3570:
-----------------------------------
I reverted the changes that were made for this issue, as it breaks the windows builds.
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3570) [classlib][awt] Png decoder does
not work on Linux x86_64
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov resolved HARMONY-3570.
--------------------------------------
Resolution: Fixed
Andrey, ok, if we aren't going to support images with height/width more than 2^31 then IMHO no update of Java code is needed. I've made another try and committed the new version of my own patch (that is similar to yours) at r529572. Please check. Big thanks to Nathan and Alexey for reporting the issues with Windows build. This was my mistake - C compiler doesn't seem to recompile stuff if only header is changed.
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3570) [classlib][awt] Png decoder does
not work on Linux x86_64
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488921 ]
Alexey Petrenko commented on HARMONY-3570:
------------------------------------------
Yes, I can reproduce the windows build failure with the original patch by Andrey and modified patch by Alexei
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3570) [classlib][awt] Png decoder does not
work on Linux x86_64
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov updated HARMONY-3570:
-------------------------------------
Component/s: Classlib
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3570) [classlib][awt] Png decoder does
not work on Linux x86_64
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov resolved HARMONY-3570.
--------------------------------------
Resolution: Fixed
Thanks Andrey. I've updated your patch a little bit - unsigned long was replaced with png_uint_32 to make things more portable. The resulted version of the patch was committed at the revision 528479. Please verify it solves the original problem on 64 bit Linux.
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3570) [classlib][awt] Png decoder does
not work on Linux x86_64
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490401 ]
Andrey Pavlenko commented on HARMONY-3570:
------------------------------------------
Alexey, the patch has been applied properly. Thanks.
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3570) [classlib][awt] Png decoder does not
work on Linux x86_64
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Pavlenko updated HARMONY-3570:
-------------------------------------
Attachment: HARMONY-3570.patch
This patch fixes the issue.
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Reporter: Andrey Pavlenko
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3570) [classlib][awt] Png decoder does not
work on Linux x86_64
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Pavlenko updated HARMONY-3570:
-------------------------------------
Attachment: HARMONY-3570.patch
I think it's ok to use int in Java code for width and height. According to the libpng spec:
The PNG specification allows the width and height of an image to be as large as 2^31-1 (0x7fffffff), or about 2.147 billion rows and columns. Since very few applications really need to process such large images, we have imposed an arbitrary 1-million limit on rows and columns.
Please try this patch.
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch, HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3570) [classlib][awt] Png decoder does not
work on Linux x86_64
Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Pavlenko updated HARMONY-3570:
-------------------------------------
Attachment: (was: HARMONY-3570.patch)
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3570) [classlib][awt] Png decoder does
not work on Linux x86_64
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov reassigned HARMONY-3570:
----------------------------------------
Assignee: Alexei Zakharov
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3570) [classlib][awt] Png decoder does not
work on Linux x86_64
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov closed HARMONY-3570.
------------------------------------
Issue closed.
> [classlib][awt] Png decoder does not work on Linux x86_64
> ---------------------------------------------------------
>
> Key: HARMONY-3570
> URL: https://issues.apache.org/jira/browse/HARMONY-3570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Andrey Pavlenko
> Assigned To: Alexei Zakharov
> Attachments: HARMONY-3570.patch
>
>
> The test attached to HARMONY-1954 fails on Linux x86_64 with png images.
> Test output:
> Fjava.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> java.lang.RuntimeException: Invalid image width
> at org.apache.harmony.awt.gl.image.PngDecoder.decode(PngDecoder.java)
> at org.apache.harmony.awt.gl.image.PngDecoder.decodeImage(PngDecoder.java:110)
> at org.apache.harmony.awt.gl.image.DecodingImageSource.load(DecodingImageSource.java:252)
> at org.apache.harmony.awt.gl.image.ImageLoader.run(ImageLoader.java:154)
> Time: 8.183
> There was 1 failure:
> 1) png(ImageDecoderTest)junit.framework.AssertionFailedError: expected:<320> but was:<-1>
> at ImageDecoderTest.decodeImage(ImageDecoderTest.java:57)
> at ImageDecoderTest.testDecodeImage(ImageDecoderTest.java:43)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.