You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "alexeykudinkin (via GitHub)" <gi...@apache.org> on 2023/02/10 04:44:14 UTC
[GitHub] [hudi] alexeykudinkin opened a new pull request, #7917: [DNM] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
alexeykudinkin opened a new pull request, #7917:
URL: https://github.com/apache/hudi/pull/7917
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7917:
URL: https://github.com/apache/hudi/pull/7917#issuecomment-1425797830
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c84c4b69a6905cd64c822a4c6563839d2a059183",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15082",
"triggerID" : "c84c4b69a6905cd64c822a4c6563839d2a059183",
"triggerType" : "PUSH"
}, {
"hash" : "83bae6b492b7965263f673189dbd6cc8804f46cc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15085",
"triggerID" : "83bae6b492b7965263f673189dbd6cc8804f46cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83bae6b492b7965263f673189dbd6cc8804f46cc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15085)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7917:
URL: https://github.com/apache/hudi/pull/7917#issuecomment-1425384061
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c84c4b69a6905cd64c822a4c6563839d2a059183",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15082",
"triggerID" : "c84c4b69a6905cd64c822a4c6563839d2a059183",
"triggerType" : "PUSH"
}, {
"hash" : "83bae6b492b7965263f673189dbd6cc8804f46cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "83bae6b492b7965263f673189dbd6cc8804f46cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c84c4b69a6905cd64c822a4c6563839d2a059183 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15082)
* 83bae6b492b7965263f673189dbd6cc8804f46cc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin merged pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin merged PR #7917:
URL: https://github.com/apache/hudi/pull/7917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7917:
URL: https://github.com/apache/hudi/pull/7917#issuecomment-1425192893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c84c4b69a6905cd64c822a4c6563839d2a059183",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15082",
"triggerID" : "c84c4b69a6905cd64c822a4c6563839d2a059183",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c84c4b69a6905cd64c822a4c6563839d2a059183 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15082)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #7917:
URL: https://github.com/apache/hudi/pull/7917#discussion_r1102295643
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/HoodieSparkKryoRegistrar.scala:
##########
@@ -44,12 +45,15 @@ import org.apache.spark.serializer.KryoRegistrator
* </ol>
*/
class HoodieSparkKryoRegistrar extends HoodieCommonKryoRegistrar with KryoRegistrator {
+
override def registerClasses(kryo: Kryo): Unit = {
///////////////////////////////////////////////////////////////////////////
// NOTE: DO NOT REORDER REGISTRATIONS
///////////////////////////////////////////////////////////////////////////
super[HoodieCommonKryoRegistrar].registerClasses(kryo)
+ kryo.register(classOf[HoodieKey], new HoodieKeySerializer)
Review Comment:
so we need this because we still want to be able to make use of serde optimization between shuffles?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDeleteBlock.java:
##########
@@ -97,6 +97,7 @@ public DeleteRecord[] getRecordsToDelete() {
}
}
+ // TODO(HUDI-5760) avoid using Kryo for serialization here
Review Comment:
Is this comment misplaced? I am assuming this is to avoid Kryo for serialization to disk. So, it should be placed before `getContentBytes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin commented on code in PR #7917:
URL: https://github.com/apache/hudi/pull/7917#discussion_r1102377837
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/HoodieSparkKryoRegistrar.scala:
##########
@@ -44,12 +45,15 @@ import org.apache.spark.serializer.KryoRegistrator
* </ol>
*/
class HoodieSparkKryoRegistrar extends HoodieCommonKryoRegistrar with KryoRegistrator {
+
override def registerClasses(kryo: Kryo): Unit = {
///////////////////////////////////////////////////////////////////////////
// NOTE: DO NOT REORDER REGISTRATIONS
///////////////////////////////////////////////////////////////////////////
super[HoodieCommonKryoRegistrar].registerClasses(kryo)
+ kryo.register(classOf[HoodieKey], new HoodieKeySerializer)
Review Comment:
@codope correct. This is still needed to make sure we're not shuffling fully-qualified class names in the payload
@vinothchandar correct. This registrar is only used on Spark's instance of Kryo used for shuffling
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDeleteBlock.java:
##########
@@ -97,6 +97,7 @@ public DeleteRecord[] getRecordsToDelete() {
}
}
+ // TODO(HUDI-5760) avoid using Kryo for serialization here
Review Comment:
Good point. Duplicated this comment in both ser/de paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7917:
URL: https://github.com/apache/hudi/pull/7917#issuecomment-1425187741
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c84c4b69a6905cd64c822a4c6563839d2a059183",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c84c4b69a6905cd64c822a4c6563839d2a059183",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c84c4b69a6905cd64c822a4c6563839d2a059183 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin commented on PR #7917:
URL: https://github.com/apache/hudi/pull/7917#issuecomment-1426457488
CI is green:
<img width="1617" alt="Screenshot 2023-02-10 at 3 02 21 PM" src="https://user-images.githubusercontent.com/428277/218218673-51fed9fb-54a7-404c-8857-3b9553d6e8a9.png">
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=15085&view=results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7917:
URL: https://github.com/apache/hudi/pull/7917#issuecomment-1425400185
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c84c4b69a6905cd64c822a4c6563839d2a059183",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15082",
"triggerID" : "c84c4b69a6905cd64c822a4c6563839d2a059183",
"triggerType" : "PUSH"
}, {
"hash" : "83bae6b492b7965263f673189dbd6cc8804f46cc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15085",
"triggerID" : "83bae6b492b7965263f673189dbd6cc8804f46cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c84c4b69a6905cd64c822a4c6563839d2a059183 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15082)
* 83bae6b492b7965263f673189dbd6cc8804f46cc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15085)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a diff in pull request #7917: [HUDI-5758] Restoring state of `HoodieKey` to make sure it's binary compatible w/ its state in 0.12
Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar commented on code in PR #7917:
URL: https://github.com/apache/hudi/pull/7917#discussion_r1102343190
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/HoodieSparkKryoRegistrar.scala:
##########
@@ -44,12 +45,15 @@ import org.apache.spark.serializer.KryoRegistrator
* </ol>
*/
class HoodieSparkKryoRegistrar extends HoodieCommonKryoRegistrar with KryoRegistrator {
+
override def registerClasses(kryo: Kryo): Unit = {
///////////////////////////////////////////////////////////////////////////
// NOTE: DO NOT REORDER REGISTRATIONS
///////////////////////////////////////////////////////////////////////////
super[HoodieCommonKryoRegistrar].registerClasses(kryo)
+ kryo.register(classOf[HoodieKey], new HoodieKeySerializer)
Review Comment:
I guess this ONLY applied to the shuffle and not for the actual serialization? i,e this instance of kryo is not a shared/singleton or sth. correcT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org