[jira] [Commented] (HBASE-7354) Snapshot Info/Debug Tool

["Jonathan Hsieh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540963#comment-13540963 ] 

Jonathan Hsieh commented on HBASE-7354:
---------------------------------------

I like.  Please add the comments (comments near where some of these questions are would be good) and please post what an example run's output looks like (instead of tests)?

change to o.a.h.h.snapshot? (my fault, HBASE-7207)
{code}
package org.apache.hadoop.hbase.snapshot.tool;
{code}

class Javadoc?  what is this for (for someone looking only at the code?)

Log when dir doesn't exist (more helpful to have dir name here -- calling site doesn't have it)
{code}
+    snapshotDir = SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshotName, rootDir);
+    if (!fs.exists(snapshotDir)) return false;
{code}

Worth showing if in archive or in original file location? (could be follow on)
{code}
+          if (showFiles) {
+            System.out.printf("%8s %s/%s/%s/%s\n",
+              StringUtils.humanReadableInt(size), table, region, family, hfile);
+          }
{code}

The storefile case had if with two branches -- this logfile link doesn't need to do this?
{code}
      public void logFile (final String server, final String logfile)
+            throws IOException {
+          HLogLink logLink = new HLogLink(conf, server, logfile);
+          long size = logLink.getFileStatus(fs).getLen();
+          logSize.addAndGet(size);
+          logsCount.addAndGet(1);
+
{code}


                
> Snapshot Info/Debug Tool
> ------------------------
>
>                 Key: HBASE-7354
>                 URL: https://issues.apache.org/jira/browse/HBASE-7354
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, master, regionserver, snapshots, Zookeeper
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: hbase-6055, 0.96.0
>
>         Attachments: HBASE-7354-v0.patch
>
>
> Tool that show snapshot metadata, hfiles and logs retained.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira