You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/25 16:05:35 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7185: libc: Move queue.h from include to include/nuttx
xiaoxiang781216 opened a new pull request, #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185
## Summary
to avoid the conflict with libuv's queue.h
## Impact
Code refactor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7185: libc: Move queue.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185#issuecomment-1257225358
Please ignore the mix case warning from arch/arm/src/phy62xx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7185: libc: Move queue.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7185: libc: Move queue.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185#discussion_r979451829
##########
include/nuttx/wdog.h:
##########
@@ -29,7 +29,6 @@
#include <nuttx/clock.h>
#include <stdint.h>
-#include <queue.h>
Review Comment:
Seems now we need to add `#include <nuttx/queue.h>` to `sched/wdog/wdog.h` as it was implicitly included till now.
After adding it code builds locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7185: libc: Move queue.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185#discussion_r979456101
##########
include/nuttx/wdog.h:
##########
@@ -29,7 +29,6 @@
#include <nuttx/clock.h>
#include <stdint.h>
-#include <queue.h>
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7185: libc: Move queue.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185#issuecomment-1257256414
Seems like some files still need to be updated
```
In file included from wdog/wd_gettime.c:30:
Error: /github/workspace/sources/nuttx/sched/wdog/wdog.h:75:8: error: unknown type name 'sq_queue_t'
75 | extern sq_queue_t g_wdactivelist;
| ^~~~~~~~~~
```
I will try to run the build locally and feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7185: libc: Move queue.h from include to include/nuttx
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7185:
URL: https://github.com/apache/incubator-nuttx/pull/7185#discussion_r979451829
##########
include/nuttx/wdog.h:
##########
@@ -29,7 +29,6 @@
#include <nuttx/clock.h>
#include <stdint.h>
-#include <queue.h>
Review Comment:
Seems now we need to add `#include <nuttx/queue.h>` to `sched/wdog/wdog.h` as it was implicitly included till now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org