[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4702: Enhance Selection Comparator

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #4702: Enhance Selection Comparator
URL: https://github.com/apache/incubator-pinot/pull/4702#discussion_r334590527
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java
 ##########
 @@ -568,4 +579,31 @@ private static Serializable getFormattedValue(Serializable value, DataSchema.Col
       queue.offer(value);
     }
   }
+
+  /**
+   * Helper class to compare rows.
+   */
 
 Review comment:
   If I understand it correctly, the purpose of valueIndices is to record the index of order by column(s) in a row. Since this comparator is fed the entire row, we need to know which column is the order by column. If that is correct, can you please add this info in javadoc for anyone using this to understand what exactly is value indices>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org