[GitHub] [airflow] mik-laj commented on a change in pull request #15419: Subtract file log reader into separate functions

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #15419:
URL: https://github.com/apache/airflow/pull/15419#discussion_r615927784



##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -261,3 +202,85 @@ def _init_file(self, ti):
                 logging.warning("OSError while change ownership of the log file")
 
         return full_path
+
+
+def read_local_log(location: str):

Review comment:
       This module has a mixed responsibility - It handles local files, remote files and k8s logs. I think we should divide it and move some part of the code to [`log_reader.py`](https://github.com/apache/airflow/blob/master/airflow/utils/log/log_reader.py), so that these functions can also be used by other handlers.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org