You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/19 09:46:22 UTC
[GitHub] [airflow] bkossakowska opened a new pull request, #28457: Add deferrable mode to DataprocCreateBatchOperator
bkossakowska opened a new pull request, #28457:
URL: https://github.com/apache/airflow/pull/28457
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Add deferrable mode to DataprocCreateBatchOperator
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28457: Add deferrable mode to DataprocCreateBatchOperator
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #28457:
URL: https://github.com/apache/airflow/pull/28457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bkossakowska commented on a diff in pull request #28457: Add deferrable mode to DataprocCreateBatchOperator
Posted by GitBox <gi...@apache.org>.
bkossakowska commented on code in PR #28457:
URL: https://github.com/apache/airflow/pull/28457#discussion_r1055210015
##########
airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -2071,17 +2073,21 @@ def __init__(
region: str | None = None,
project_id: str | None = None,
batch: dict | Batch,
- batch_id: str | None = None,
+ batch_id: str,
request_id: str | None = None,
retry: Retry | _MethodDefault = DEFAULT,
timeout: float | None = None,
metadata: Sequence[tuple[str, str]] = (),
gcp_conn_id: str = "google_cloud_default",
impersonation_chain: str | Sequence[str] | None = None,
result_retry: Retry | _MethodDefault = DEFAULT,
+ deferrable: bool = False,
+ poll_interval: int = 5,
**kwargs,
):
super().__init__(**kwargs)
+ if deferrable and poll_interval <= 0:
+ raise ValueError("Invalid value for polling_interval_seconds. Expected value greater than 0")
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bkossakowska commented on pull request #28457: Add deferrable mode to DataprocCreateBatchOperator
Posted by "bkossakowska (via GitHub)" <gi...@apache.org>.
bkossakowska commented on PR #28457:
URL: https://github.com/apache/airflow/pull/28457#issuecomment-1408290061
Hi @potiuk,
Is it possible to review and merge this PR?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28457: Add deferrable mode to DataprocCreateBatchOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28457:
URL: https://github.com/apache/airflow/pull/28457#issuecomment-1384630289
Needs conflict resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #28457: Add deferrable mode to DataprocCreateBatchOperator
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #28457:
URL: https://github.com/apache/airflow/pull/28457#discussion_r1052188688
##########
airflow/providers/google/cloud/operators/dataproc.py:
##########
@@ -2071,17 +2073,21 @@ def __init__(
region: str | None = None,
project_id: str | None = None,
batch: dict | Batch,
- batch_id: str | None = None,
+ batch_id: str,
request_id: str | None = None,
retry: Retry | _MethodDefault = DEFAULT,
timeout: float | None = None,
metadata: Sequence[tuple[str, str]] = (),
gcp_conn_id: str = "google_cloud_default",
impersonation_chain: str | Sequence[str] | None = None,
result_retry: Retry | _MethodDefault = DEFAULT,
+ deferrable: bool = False,
+ poll_interval: int = 5,
**kwargs,
):
super().__init__(**kwargs)
+ if deferrable and poll_interval <= 0:
+ raise ValueError("Invalid value for polling_interval_seconds. Expected value greater than 0")
Review Comment:
Typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org