[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3282: Bump ranger version from 2.2.0 to 2.3.0

[GitBox <gi...@apache.org>]

Yikf commented on code in PR #3282:
URL: https://github.com/apache/incubator-kyuubi/pull/3282#discussion_r953735945


##########
extensions/spark/kyuubi-spark-authz/src/test/resources/logback.xml:
##########
@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+<configuration>

Review Comment:
   1) Apache Ranger has a bug, the NPE[1][2], which is present in versions 2.2.0 and 3.3.0
   
   2) The condition for this problem to recur is to start DEBUG level logging
   
   3) The reason this issue was not found on Apache Kyuubi at Apache Ranger 2.2.0 is that Apache Ranger uses log4j on version 2.2.0 and our log configuration is not debug level
   
   4) This problem occurred after the upgrade to 2.3.0. This is because Apache Ranger uses logback instead of log4j in version 2.3.0[2]. The default level is Debug, and Apache Kyuubi does not have the corresponding log configuration file
   
   Therefore, this PR will incidentally add a logback.xml
   
   [1] [JIRA] https://issues.apache.org/jira/browse/RANGER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel
   [2] [BUG code] https://github.com/apache/ranger/blob/ce3339c8ab653d99382caba9b2e5f306a7118561/agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java#L991
   [3][remove log4j]  https://issues.apache.org/jira/browse/RANGER-3498



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org