You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Rall <dl...@finemaltcoding.com> on 2007/09/13 17:29:04 UTC
Re: svn commit: r26574 - trunk/subversion/tests/cmdline
On Sep 12, 2007, at 10:48 PM, lgo@tigris.org wrote:
...
> Fix random Windows buildbot errors: the tests currently cache the
> credentials,
> but when running the tests in parallel you can't rely on them being
> the
> credentials you expect. Solution is to always explicitly pass the
> credentials
> you want to use.
>
> * subversion/tests/cmdline/lock_tests.py
> (commit_propchange): specify username and password for the commit.
>
>
> Modified:
> trunk/subversion/tests/cmdline/lock_tests.py
>
> Modified: trunk/subversion/tests/cmdline/lock_tests.py
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/tests/
> cmdline/lock_tests.py?pathrev=26574&r1=26573&r2=26574
> ======================================================================
> ========
> --- trunk/subversion/tests/cmdline/lock_tests.py (original)
> +++ trunk/subversion/tests/cmdline/lock_tests.py Wed Sep 12
> 22:48:21 2007
> @@ -181,7 +181,10 @@
>
> # make a property change and commit it, allowing lock to be
> released
> svntest.main.run_svn(None, 'propset', 'blue', 'azul', file_path)
> - svntest.main.run_svn(None, 'commit', '-m', '', file_path)
> + svntest.main.run_svn(None, 'commit',
> + '--username', svntest.main.wc_author,
> + '--password', svntest.main.wc_passwd,
> + '-m', '', file_path)
...
Is this necessary anywhere that we use run_svn()? I just added more
usage of it to actions.py...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svntest: Adding --username and --password to run_svn()
Posted by "C. Michael Pilato" <cm...@collab.net>.
Daniel Rall wrote:
>
> On Sep 13, 2007, at 10:29 AM, Daniel Rall wrote:
>
>>
>> On Sep 12, 2007, at 10:48 PM, lgo@tigris.org wrote:
>> ...
>>> Fix random Windows buildbot errors: the tests currently cache the
>>> credentials,
>>> but when running the tests in parallel you can't rely on them being the
>>> credentials you expect. Solution is to always explicitly pass the
>>> credentials
>>> you want to use.
>>>
>>> * subversion/tests/cmdline/lock_tests.py
>>> (commit_propchange): specify username and password for the commit.
>>>
>>>
>>> Modified:
>>> trunk/subversion/tests/cmdline/lock_tests.py
>>>
>>> Modified: trunk/subversion/tests/cmdline/lock_tests.py
>>> URL:
>>> http://svn.collab.net/viewvc/svn/trunk/subversion/tests/cmdline/lock_tests.py?pathrev=26574&r1=26573&r2=26574
>>>
>>> ==============================================================================
>>>
>>> --- trunk/subversion/tests/cmdline/lock_tests.py (original)
>>> +++ trunk/subversion/tests/cmdline/lock_tests.py Wed Sep 12
>>> 22:48:21 2007
>>> @@ -181,7 +181,10 @@
>>>
>>> # make a property change and commit it, allowing lock to be released
>>> svntest.main.run_svn(None, 'propset', 'blue', 'azul', file_path)
>>> - svntest.main.run_svn(None, 'commit', '-m', '', file_path)
>>> + svntest.main.run_svn(None, 'commit',
>>> + '--username', svntest.main.wc_author,
>>> + '--password', svntest.main.wc_passwd,
>>> + '-m', '', file_path)
>> ...
>>
>> Is this necessary anywhere that we use run_svn()? I just added more
>> usage of it to actions.py...
>
> In r26582, I updated my recent changes with those arguments. However,
> should we instead modify run_svn() to add them when they aren't
> specified (or something of the kind)?
That's fine with me. run_svn() would have to scan its arguments to know if
the 'svn' command it was about to run accepts those options (otherwise 'svn'
would error out).
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: svntest: Adding --username and --password to run_svn()
Posted by Lieven Govaerts <sv...@mobsol.be>.
Daniel Rall wrote:
>
> On Sep 13, 2007, at 10:29 AM, Daniel Rall wrote:
>
>> On Sep 12, 2007, at 10:48 PM, lgo@tigris.org wrote:
>> ...
>>> # make a property change and commit it, allowing lock to be released
>>> svntest.main.run_svn(None, 'propset', 'blue', 'azul', file_path)
>>> - svntest.main.run_svn(None, 'commit', '-m', '', file_path)
>>> + svntest.main.run_svn(None, 'commit',
>>> + '--username', svntest.main.wc_author,
>>> + '--password', svntest.main.wc_passwd,
>>> + '-m', '', file_path)
>> ...
>>
>> Is this necessary anywhere that we use run_svn()? I just added more
>> usage of it to actions.py...
>
> In r26582, I updated my recent changes with those arguments. However,
> should we instead modify run_svn() to add them when they aren't
> specified (or something of the kind)?
>
Dan,
there have been some discussions about this topic lately:
http://svn.haxx.se/dev/archive-2007-05/0388.shtml
http://svn.haxx.se/dev/archive-2007-06/0518.shtml
I think we should:
- disable creds caching for all tests (through the config file)
- make all functions in actions.py and main.py take a username and pwd
parameter
- let them default to 'jrandom' and '**********' (you know the passwd,
I'm not sharing it on a public mailing list ;), so we don't have to
specify those on all 1000+ usages of run_svn*.
- modify all tests using jconstant to explicitly set user & pwd.
I'm willing to work on this, but not before 1.5 is released. I only have
evenings available to work on svn and there is lots of (ra_)serf work
left to do.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
svntest: Adding --username and --password to run_svn()
Posted by Daniel Rall <dl...@finemaltcoding.com>.
On Sep 13, 2007, at 10:29 AM, Daniel Rall wrote:
>
> On Sep 12, 2007, at 10:48 PM, lgo@tigris.org wrote:
> ...
>> Fix random Windows buildbot errors: the tests currently cache the
>> credentials,
>> but when running the tests in parallel you can't rely on them
>> being the
>> credentials you expect. Solution is to always explicitly pass the
>> credentials
>> you want to use.
>>
>> * subversion/tests/cmdline/lock_tests.py
>> (commit_propchange): specify username and password for the commit.
>>
>>
>> Modified:
>> trunk/subversion/tests/cmdline/lock_tests.py
>>
>> Modified: trunk/subversion/tests/cmdline/lock_tests.py
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/tests/
>> cmdline/lock_tests.py?pathrev=26574&r1=26573&r2=26574
>> =====================================================================
>> =========
>> --- trunk/subversion/tests/cmdline/lock_tests.py (original)
>> +++ trunk/subversion/tests/cmdline/lock_tests.py Wed Sep 12
>> 22:48:21 2007
>> @@ -181,7 +181,10 @@
>>
>> # make a property change and commit it, allowing lock to be
>> released
>> svntest.main.run_svn(None, 'propset', 'blue', 'azul', file_path)
>> - svntest.main.run_svn(None, 'commit', '-m', '', file_path)
>> + svntest.main.run_svn(None, 'commit',
>> + '--username', svntest.main.wc_author,
>> + '--password', svntest.main.wc_passwd,
>> + '-m', '', file_path)
> ...
>
> Is this necessary anywhere that we use run_svn()? I just added
> more usage of it to actions.py...
In r26582, I updated my recent changes with those arguments.
However, should we instead modify run_svn() to add them when they
aren't specified (or something of the kind)?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org