You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/16 18:01:28 UTC

[GitHub] [airflow] jmorgannht opened a new issue #17639: Airflow API (Stable) (1.0.0) Update a DAG endpoint documentation shows you can update is_active, but the api does not accept it

jmorgannht opened a new issue #17639:
URL: https://github.com/apache/airflow/issues/17639


   **Apache Airflow version**:
   
   v2.1.1+astro.2
   
   **OS**:
   
   Ubuntu v18.04
   
   **Apache Airflow Provider versions**:
   
   <!-- You can use `pip freeze | grep apache-airflow-providers` (you can leave only relevant ones)-->
   
   **Deployment**:
   
   VM
   
   Ansible
   
   **What happened**:
   
   PATCH call to api/v1/dags/{dagID} gives the following response when is_active is included in the update mask and/or body: 
   {
       "detail": "Only `is_paused` field can be updated through the REST API",
       "status": 400,
       "title": "Bad Request",
       "type": "http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow/latest/stable-rest-api-ref.html#section/Errors/BadRequest"
   }
   
   The API spec clearly indicates is_active is a modifiable field: https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/patch_dag
   
   **What you expected to happen**:
   
   Expected the is_active field to be updated in the DAG.  Either fix the endpoint or fix the documentation.
   
   **How to reproduce it**:
   
   Send PATCH call to api/v1/dags/{dagID} with "is_active": true/false in the body
   
   **Anything else we need to know**:
   
   Occurs every time.  
   
   **Are you willing to submit a PR?**
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #17639: Airflow API (Stable) (1.0.0) Update a DAG endpoint documentation shows you can update is_active, but the api does not accept it

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #17639:
URL: https://github.com/apache/airflow/issues/17639#issuecomment-899920441


   You're right. We should add readOnly=True property to `is_active` field. It should look similar to `is_subdag` field. 
   https://github.com/apache/airflow/blob/2935be19901467c645bce9d134e28335f2aee7d8/airflow/api_connexion/openapi/v1.yaml#L1871-L1882


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17639: Airflow API (Stable) (1.0.0) Update a DAG endpoint documentation shows you can update is_active, but the api does not accept it

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #17639:
URL: https://github.com/apache/airflow/issues/17639#issuecomment-899707519


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed issue #17639: Airflow API (Stable) (1.0.0) Update a DAG endpoint documentation shows you can update is_active, but the api does not accept it

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #17639:
URL: https://github.com/apache/airflow/issues/17639


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed issue #17639: Airflow API (Stable) (1.0.0) Update a DAG endpoint documentation shows you can update is_active, but the api does not accept it

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #17639:
URL: https://github.com/apache/airflow/issues/17639


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org