You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/21 14:00:19 UTC

[GitHub] [arrow] bkietz commented on a change in pull request #6959: ARROW-5649: [Integration][C++] Create integration test for extension types

bkietz commented on a change in pull request #6959:
URL: https://github.com/apache/arrow/pull/6959#discussion_r412194818



##########
File path: dev/archery/archery/integration/datagen.py
##########
@@ -1401,6 +1437,18 @@ def generate_nested_dictionary_case():
                           dictionaries=[dict0, dict1, dict2])
 
 
+def generate_extension_case():
+    uuid_type = ExtensionType('uuid', 'uuid-serialization',
+                              FixedSizeBinaryField('', 16))
+
+    fields = [
+        ExtensionField('uuids', uuid_type),

Review comment:
       Should we also test dictionary(ext) and ext(storage=dictionary)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org