[jira] [Commented] (HADOOP-13470) GenericTestUtils$LogCapturer is flaky

["Mingliang Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-13470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408902#comment-15408902 ] 

Mingliang Liu commented on HADOOP-13470:
----------------------------------------

Ping [~jnp] and [~arpitagarwal].

> GenericTestUtils$LogCapturer is flaky
> -------------------------------------
>
>                 Key: HADOOP-13470
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13470
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test, util
>    Affects Versions: 2.8.0
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HADOOP-13470.000.patch
>
>
> {{GenericTestUtils$LogCapturer}} is useful for assertions against service logs. However it should be fixed in following aspects:
> # In the constructor, it uses the stdout appender's layout.
> {code}
> Layout layout = Logger.getRootLogger().getAppender("stdout").getLayout();
> {code}
> However, the stdout appender may be named "console" or alike which makes the constructor throw NPE. Actually the layout does not matter and we can use a default pattern layout that only captures application logs.
> # {{stopCapturing()}} method is not working. The major reason is that the {{appender}} internal variable is never assigned and thus removing it to stop capturing makes no sense.
> # It does not support {{org.slf4j.Logger}} which is preferred to log4j in many modules.
> # There is no unit test for it.
> This jira is to address these.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org