[GitHub] spark pull request #16451: [SPARK-18922][SQL][CORE][STREAMING][TESTS] Fix al...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16451#discussion_r94569924
  
    --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala ---
    @@ -138,10 +139,15 @@ class KafkaTestUtils extends Logging {
     
         if (server != null) {
           server.shutdown()
    +      server.awaitShutdown()
           server = null
         }
     
    -    brokerConf.logDirs.foreach { f => Utils.deleteRecursively(new File(f)) }
    +    // On Windows, `logDirs` is left open even after Kafka server above is completely shut-downed
    +    // in some cases. It leads to test failures on Windows if these are not ignored.
    +    brokerConf.logDirs.map(new File(_))
    --- End diff --
    
    It really looks an issue in Kafka. The broker seems shut-downed without closing the log directories in some cases. This directories are Kafka specified directories.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org