[GitHub] [beam] damccorm commented on a diff in pull request #23092: Cross-langauge tests in github actions.

[GitBox <gi...@apache.org>]

damccorm commented on code in PR #23092:
URL: https://github.com/apache/beam/pull/23092#discussion_r966223079


##########
sdks/typescript/test/io_test.ts:
##########
@@ -59,13 +59,17 @@ before(() => {
 
 after(() => subprocessCache.stopAll());
 
+function xlang_it(name, fn) {
+  return (process.env.BEAM_SERVICE_OVERRIDES ? it : it.skip)(name + ' @xlang', fn);
+}
+
 // These depends on fixes that will be released in 2.40.
 // They can be run manually by setting an environment variable
-// expor tBEAM_SERVICE_OVERRIDES = '{python:*": "/path/to/dev/venv/bin/python"}'
+// export BEAM_SERVICE_OVERRIDES = '{python:*": "/path/to/dev/venv/bin/python"}'
 // TODO: Automatically set up/depend on such a venv in dev environments and/or
 // testing infra.
-xdescribe("IO Tests", function () {
-  it("textio file test", async function () {
+describe("IO Tests", function () {
+  xit("textio file test", async function () {

Review Comment:
   ```suggestion
     xlang_it("textio file test", async function () {
   ```



##########
.github/workflows/typescript_tests.yml:
##########
@@ -64,3 +64,38 @@ jobs:
       - run: npm test
         working-directory: ./sdks/typescript
 #        if: ${{ matrix.os != 'ubuntu-latest' }}
+
+  typescript_xlang_tests:
+    name: 'TypeScript xlang Tests'
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+          submodules: recursive
+      - name: Install node
+        uses: actions/setup-node@v3
+        with:
+          node-version: '16'
+      - name: Install python
+        uses: actions/setup-python@v4
+        with:
+          python-version: 3.8
+      - name: Setup Beam Python
+        working-directory: ./sdks/python
+        run: |
+          pip install pip setuptools --upgrade
+          pip install -r build-requirements.txt
+          pip install 'pandas>=1.0,<1.5'

Review Comment:
   Why do we end up needing a special pandas install?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org