[GitHub] [echarts] 100pah commented on a diff in pull request #18381: feat(ssr): server-side rendering and client hydration #18334

["100pah (via GitHub)" <gi...@apache.org>]

100pah commented on code in PR #18381:
URL: https://github.com/apache/echarts/pull/18381#discussion_r1193190493


##########
src/util/innerStore.ts:
##########
@@ -70,7 +70,19 @@ export const setCommonECData = (seriesIndex: number, dataType: SeriesDataType, d
                 childECData.seriesIndex = seriesIndex;
                 childECData.dataIndex = dataIdx;
                 childECData.dataType = dataType;
+                child.__metaData = {

Review Comment:
   `setCommonECData` is probably not designed for only "seriesItem", see "progress" in GaugeView.
   And I am worried that it's not a good idea to give each el a extra object to save seriesIndex and dataIndex, particularly the already save in ecData.
   
   Could we move `makeInner` to zrender, and create `getECData` in zrender (with another name) and visit the "ecData" in zrender to  get seriesIndex and dataIndex?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org