You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Felix Meschberger <fm...@gmail.com> on 2008/06/16 16:00:15 UTC
Re: svn commit: r668162 -
/incubator/sling/trunk/servlets/get/pom.xml
Hi,
I am not a fan of this. I did not export the renderes by intent. I am
not sure, where we are heading with these and I do not want to burn some
API we cannot sustain...
And I am not sure, we should do this just for JST ! Rather we should
include the renderers as private packages into the JST bundle if need
be.
Regards
Felix
Am Montag, den 16.06.2008, 13:54 +0000 schrieb bdelacretaz@apache.org:
> Author: bdelacretaz
> Date: Mon Jun 16 06:54:45 2008
> New Revision: 668162
>
> URL: http://svn.apache.org/viewvc?rev=668162&view=rev
> Log:
> SLING-466 - export the org.apache.sling.servlets.get.helpers package: reusable default renderers
>
> Modified:
> incubator/sling/trunk/servlets/get/pom.xml
>
> Modified: incubator/sling/trunk/servlets/get/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/sling/trunk/servlets/get/pom.xml?rev=668162&r1=668161&r2=668162&view=diff
> ==============================================================================
> --- incubator/sling/trunk/servlets/get/pom.xml (original)
> +++ incubator/sling/trunk/servlets/get/pom.xml Mon Jun 16 06:54:45 2008
> @@ -56,9 +56,11 @@
> <configuration>
> <instructions>
> <Private-Package>
> - org.apache.sling.servlets.get.*
> + org.apache.sling.servlets.get.* ; -split-package:=merge-first
> </Private-Package>
> -
> + <Export-Package>
> + org.apache.sling.servlets.get.helpers
> + </Export-Package>
> <Sling-Nodetypes>
> SLING-INF/nodetypes/redirect.cnd
> </Sling-Nodetypes>
>
>
Re: svn commit: r668162 -
/incubator/sling/trunk/servlets/get/pom.xml
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
Thanks and Regards
Felix
Am Montag, den 16.06.2008, 16:04 +0200 schrieb Bertrand Delacretaz:
> On Mon, Jun 16, 2008 at 4:00 PM, Felix Meschberger <fm...@gmail.com> wrote:
> > ...I am not sure, we should do this just for JST ! Rather we should
> > include the renderers as private packages into the JST bundle if need
> > be....
>
> Ok, I see your point - I'll revert and use the renderers as private packages.
>
> The "right" way might be to create a separate bundle with those
> renderers, but we don't need this right now.
>
> -Bertrand
>
> >
> > Regards
> > Felix
> >
> > Am Montag, den 16.06.2008, 13:54 +0000 schrieb bdelacretaz@apache.org:
> >> Author: bdelacretaz
> >> Date: Mon Jun 16 06:54:45 2008
> >> New Revision: 668162
> >>
> >> URL: http://svn.apache.org/viewvc?rev=668162&view=rev
> >> Log:
> >> SLING-466 - export the org.apache.sling.servlets.get.helpers package: reusable default renderers
> >>
> >> Modified:
> >> incubator/sling/trunk/servlets/get/pom.xml
> >>
> >> Modified: incubator/sling/trunk/servlets/get/pom.xml
> >> URL: http://svn.apache.org/viewvc/incubator/sling/trunk/servlets/get/pom.xml?rev=668162&r1=668161&r2=668162&view=diff
> >> ==============================================================================
> >> --- incubator/sling/trunk/servlets/get/pom.xml (original)
> >> +++ incubator/sling/trunk/servlets/get/pom.xml Mon Jun 16 06:54:45 2008
> >> @@ -56,9 +56,11 @@
> >> <configuration>
> >> <instructions>
> >> <Private-Package>
> >> - org.apache.sling.servlets.get.*
> >> + org.apache.sling.servlets.get.* ; -split-package:=merge-first
> >> </Private-Package>
> >> -
> >> + <Export-Package>
> >> + org.apache.sling.servlets.get.helpers
> >> + </Export-Package>
> >> <Sling-Nodetypes>
> >> SLING-INF/nodetypes/redirect.cnd
> >> </Sling-Nodetypes>
> >>
> >>
> >
> >
>
>
>
Re: svn commit: r668162 - /incubator/sling/trunk/servlets/get/pom.xml
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Mon, Jun 16, 2008 at 4:00 PM, Felix Meschberger <fm...@gmail.com> wrote:
> ...I am not sure, we should do this just for JST ! Rather we should
> include the renderers as private packages into the JST bundle if need
> be....
Ok, I see your point - I'll revert and use the renderers as private packages.
The "right" way might be to create a separate bundle with those
renderers, but we don't need this right now.
-Bertrand
>
> Regards
> Felix
>
> Am Montag, den 16.06.2008, 13:54 +0000 schrieb bdelacretaz@apache.org:
>> Author: bdelacretaz
>> Date: Mon Jun 16 06:54:45 2008
>> New Revision: 668162
>>
>> URL: http://svn.apache.org/viewvc?rev=668162&view=rev
>> Log:
>> SLING-466 - export the org.apache.sling.servlets.get.helpers package: reusable default renderers
>>
>> Modified:
>> incubator/sling/trunk/servlets/get/pom.xml
>>
>> Modified: incubator/sling/trunk/servlets/get/pom.xml
>> URL: http://svn.apache.org/viewvc/incubator/sling/trunk/servlets/get/pom.xml?rev=668162&r1=668161&r2=668162&view=diff
>> ==============================================================================
>> --- incubator/sling/trunk/servlets/get/pom.xml (original)
>> +++ incubator/sling/trunk/servlets/get/pom.xml Mon Jun 16 06:54:45 2008
>> @@ -56,9 +56,11 @@
>> <configuration>
>> <instructions>
>> <Private-Package>
>> - org.apache.sling.servlets.get.*
>> + org.apache.sling.servlets.get.* ; -split-package:=merge-first
>> </Private-Package>
>> -
>> + <Export-Package>
>> + org.apache.sling.servlets.get.helpers
>> + </Export-Package>
>> <Sling-Nodetypes>
>> SLING-INF/nodetypes/redirect.cnd
>> </Sling-Nodetypes>
>>
>>
>
>
--
Bertrand Delacretaz
http://www.codeconsult.ch