[GitHub] [spark] MaxGekk commented on a change in pull request #32896: [SPARK-35748][SS][SQL] Fix StreamingJoinHelper to be able to handle day-time interval

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #32896:
URL: https://github.com/apache/spark/pull/32896#discussion_r650696194



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/StreamingJoinHelper.scala
##########
@@ -266,6 +266,9 @@ object StreamingJoinHelper extends PredicateHelper with Logging {
                 Literal(calendarInterval.days * MICROS_PER_DAY.toDouble +
                   calendarInterval.microseconds.toDouble)
               }
+            case _: DayTimeIntervalType =>
+              // Unbox and then cast
+              Literal(lit.value.asInstanceOf[Long].toDouble)

Review comment:
       Using doubles looks slightly strange but you follow the code around. I am fine with the changes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org