[GitHub] [airflow] ashb commented on a change in pull request #12858: Store per-task TIDeps in serialized blob

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #12858:
URL: https://github.com/apache/airflow/pull/12858#discussion_r537117781



##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -375,6 +379,21 @@ def serialize_operator(cls, op: BaseOperator) -> dict:
                 op.operator_extra_links
             )
 
+        if op.deps is not BaseOperator.deps:
+            # Are the deps different to BaseOperator, if so serialize the class names!
+            # For Airflow 2.0 expediency we _only_ allow built in Dep classes.
+            # Fix this for 2.0.x or 2.1
+            deps = []
+            for dep in op.deps:
+                klass = type(dep)
+                module_name = klass.__module__
+                if not module_name.startswith("airflow.ti_deps.deps."):
+                    # Throw? Log?

Review comment:
       :D 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org