You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/11/18 03:27:46 UTC

Review Request 15637: SQOOP-1235 Sqoop2: Repository should be immutable by default

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15637/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1235
    https://issues.apache.org/jira/browse/SQOOP-1235


Repository: sqoop-sqoop2


Description
-------

Changed the default value to true.


Diffs
-----

  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 25d5d9d03532c677b524512aa0d175c969805b10 

Diff: https://reviews.apache.org/r/15637/diff/


Testing
-------

Unit and integration tests seems to be passing.


Thanks,

Jarek Cecho


Re: Review Request 15637: SQOOP-1235 Sqoop2: Repository should be immutable by default

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15637/#review29533
-----------------------------------------------------------

Ship it!


Ship It!

- Venkat Ranganathan


On Nov. 18, 2013, 2:27 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15637/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 2:27 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1235
>     https://issues.apache.org/jira/browse/SQOOP-1235
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Changed the default value to true.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 25d5d9d03532c677b524512aa0d175c969805b10 
> 
> Diff: https://reviews.apache.org/r/15637/diff/
> 
> 
> Testing
> -------
> 
> Unit and integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request 15637: SQOOP-1235 Sqoop2: Repository should be immutable by default

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15637/#review29502
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Elmahrek


On Nov. 18, 2013, 2:27 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15637/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 2:27 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1235
>     https://issues.apache.org/jira/browse/SQOOP-1235
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Changed the default value to true.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 25d5d9d03532c677b524512aa0d175c969805b10 
> 
> Diff: https://reviews.apache.org/r/15637/diff/
> 
> 
> Testing
> -------
> 
> Unit and integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request 15637: SQOOP-1235 Sqoop2: Repository should be immutable by default

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15637/#review47400
-----------------------------------------------------------

Ship it!


Ship It!

- Venkat Ranganathan


On July 6, 2014, 5:35 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15637/
> -----------------------------------------------------------
> 
> (Updated July 6, 2014, 5:35 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1235
>     https://issues.apache.org/jira/browse/SQOOP-1235
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Changed the default value to true.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 8f955ad 
> 
> Diff: https://reviews.apache.org/r/15637/diff/
> 
> 
> Testing
> -------
> 
> Unit and integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request 15637: SQOOP-1235 Sqoop2: Repository should be immutable by default

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15637/
-----------------------------------------------------------

(Updated July 6, 2014, 5:35 p.m.)


Review request for Sqoop.


Changes
-------

Rebasing on head of sqoop2 branch.


Bugs: SQOOP-1235
    https://issues.apache.org/jira/browse/SQOOP-1235


Repository: sqoop-sqoop2


Description
-------

Changed the default value to true.


Diffs (updated)
-----

  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 8f955ad 

Diff: https://reviews.apache.org/r/15637/diff/


Testing
-------

Unit and integration tests seems to be passing.


Thanks,

Jarek Cecho