You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/17 06:49:57 UTC
[GitHub] [spark] eejbyfeldt opened a new pull request, #38282: [SPARK-40803][CORE] Look up config items on codec creation.
eejbyfeldt opened a new pull request, #38282:
URL: https://github.com/apache/spark/pull/38282
### What changes were proposed in this pull request?
This moves look up of the `IO_COMPRESSION_LZ4_BLOCKSIZE` and `IO_COMPRESSION_SNAPPY_BLOCKSIZE` to the constructor instead of the method `compressedOutputStream`. This is already how it done for `IO_COMPRESSION_ZSTD_BUFFERSIZE` in `ZStdCompressionCodec`.
### Why are the changes needed?
The cost of looking up the config is often insignificant, but there are cases like a large shuffle with high number of partitions and therefore lots of small streams where the overhead becomes measurable (seen as high as a couple of % of executor cpu time).
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38282: [SPARK-40803][CORE] Look up config items on codec creation.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38282:
URL: https://github.com/apache/spark/pull/38282#issuecomment-1280477597
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #38282: [SPARK-40803][CORE] Look up config items on codec creation.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #38282: [SPARK-40803][CORE] Look up config items on codec creation.
URL: https://github.com/apache/spark/pull/38282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38282: [SPARK-40803][CORE] Look up config items on codec creation.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38282:
URL: https://github.com/apache/spark/pull/38282#issuecomment-1280584881
Merged to master for Apache Spark 3.4.0. Thank you, @eejbyfeldt and @HyukjinKwon .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org