You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/25 22:41:20 UTC
[jira] [Commented] (IGNITE-3323) Get rid of copypasted JB
annotations, use dependency instead.
[ https://issues.apache.org/jira/browse/IGNITE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392782#comment-15392782 ]
ASF GitHub Bot commented on IGNITE-3323:
----------------------------------------
GitHub user jayho opened a pull request:
https://github.com/apache/ignite/pull/895
IGNITE-3323 Use maven dependencies for Jetbrains annotations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jayho/ignite ignite-3323
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/895.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #895
----
commit 4fe63750a0130d2c8b854a82ec6547a75d37d14b
Author: Jens Hoffmann <jc...@gmail.com>
Date: 2016-07-25T22:38:13Z
IGNITE-3323 Use maven dependencies for Jetbrains annotations
----
> Get rid of copypasted JB annotations, use dependency instead.
> -------------------------------------------------------------
>
> Key: IGNITE-3323
> URL: https://issues.apache.org/jira/browse/IGNITE-3323
> Project: Ignite
> Issue Type: Task
> Affects Versions: 1.5.0.final
> Reporter: Anton Vinogradov
> Assignee: Jens Hoffmann
> Priority: Minor
> Labels: newbie
> Fix For: 1.7
>
>
> From user request:
> {quote}
> I've come across an issue where there are a couple of classes duplicated from org.jetbrains.annotations within the ignite-core module which conflict with other part of our code base.
> As these files are duplicated rather than being referenced as a maven dependency I am unable to exclude them or reference a specific version of the org.jetbrains.annotations artifact.
> Specifically, the included version cannot be used to annotate types
> ignite-core-1.6.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, ElementType.LOCAL_VARIABLE})
> annotations-15.0.jar:org.jetbrains.annotations.Nullable ...
> @Target({ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER, ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE})
> As far as I know there isn't an easy way of excluding these files from within the ignite-core module. Is there are reason why these "external" files have been duplicated within the ignite code base rather than being referenced as a maven dependency? Or alternatively, has anyone come across a way of avoiding these conflicts?
> {quote}
> Seems we have to remove these classes from Ignite code and use maven dependency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)