You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sgilmore10 (via GitHub)" <gi...@apache.org> on 2023/06/20 13:16:33 UTC

[GitHub] [arrow] sgilmore10 commented on a diff in pull request #36167: GH-36166: [C++][MATLAB] Add utility to convert UTF-8 strings to UTF-16 and UTF-16 strings to UTF-8

sgilmore10 commented on code in PR #36167:
URL: https://github.com/apache/arrow/pull/36167#discussion_r1235253118


##########
cpp/src/arrow/util/utf8.cc:
##########
@@ -164,5 +176,21 @@ ARROW_EXPORT Result<std::string> WideStringToUTF8(const std::wstring& source) {
   }
 }
 
+ARROW_EXPORT Result<std::string> UTF16StringToUTF8(const std::u16string& source) {

Review Comment:
   Oh that's my bad. I copied the line from the header file but forgot to delete `ARROW_EXPORT`. I'll submit a followup pull request.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org