You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org> on 2006/12/22 21:24:20 UTC

[jira] Created: (QPID-229) Alter implementation of FieldTable to encapsualte each type in its own enum instance

Alter implementation of FieldTable to encapsualte each type in its own enum instance
------------------------------------------------------------------------------------

                 Key: QPID-229
                 URL: http://issues.apache.org/jira/browse/QPID-229
             Project: Qpid
          Issue Type: Improvement
          Components: Java Common
            Reporter: Rob Godfrey
            Priority: Minor


After implementing the JMSMapMessage as a Stream Message, rather than a FieldTable, now implement FieldTable in a way that removes the need for it to pretend that it is a true Map.  Also encapsulate the behaviour of eaxch of the AMQ Types into an enum instance to take out the lengthy case statements in the code.

As FieldTable is no longer a Map, some code in HeadersExchange also needs changin

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (QPID-229) Alter implementation of FieldTable to encapsualte each type in its own enum instance

Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/QPID-229?page=all ]

Rob Godfrey updated QPID-229:
-----------------------------

    Attachment: QPID-229.patch

As described - change FieldTable / PropertyFieldTable so that it no longer has to behave as a map.

Internally it can be represented as a Map (String->(Type,Object)).

We no longer need two separate maps internally.

> Alter implementation of FieldTable to encapsualte each type in its own enum instance
> ------------------------------------------------------------------------------------
>
>                 Key: QPID-229
>                 URL: http://issues.apache.org/jira/browse/QPID-229
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Common
>            Reporter: Rob Godfrey
>            Priority: Minor
>         Attachments: QPID-229.patch
>
>
> After implementing the JMSMapMessage as a Stream Message, rather than a FieldTable, now implement FieldTable in a way that removes the need for it to pretend that it is a true Map.  Also encapsulate the behaviour of eaxch of the AMQ Types into an enum instance to take out the lengthy case statements in the code.
> As FieldTable is no longer a Map, some code in HeadersExchange also needs changin

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (QPID-229) Alter implementation of FieldTable to encapsualte each type in its own enum instance

Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Godfrey reassigned QPID-229:
--------------------------------

    Assignee: Rob Godfrey

> Alter implementation of FieldTable to encapsualte each type in its own enum instance
> ------------------------------------------------------------------------------------
>
>                 Key: QPID-229
>                 URL: https://issues.apache.org/jira/browse/QPID-229
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Common
>            Reporter: Rob Godfrey
>         Assigned To: Rob Godfrey
>            Priority: Minor
>         Attachments: QPID-229.patch
>
>
> After implementing the JMSMapMessage as a Stream Message, rather than a FieldTable, now implement FieldTable in a way that removes the need for it to pretend that it is a true Map.  Also encapsulate the behaviour of eaxch of the AMQ Types into an enum instance to take out the lengthy case statements in the code.
> As FieldTable is no longer a Map, some code in HeadersExchange also needs changin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (QPID-229) Alter implementation of FieldTable to encapsualte each type in its own enum instance

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie resolved QPID-229.
---------------------------------

    Resolution: Fixed

Revision: 489804
Author: rgreig
Date: 23:55:13, 22 December 2006
Message:
QPID-229 Fixed spurious import in test class
----
Modified : /incubator/qpid/trunk/qpid/java/client/src/test/java/org/apache/qpid/test/unit/message/JMSDestinationTest.java


Revision: 489754
Author: rgreig
Date: 20:46:54, 22 December 2006
Message:
QPID-229 : Patch supplied by Rob Godfrey - Change implementation of FieldTable
----
Modified : /incubator/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/framing/EncodingUtils.java


Revision: 489748
Author: rgreig
Date: 20:32:43, 22 December 2006
Message:
QPID-229 : Patch supplied by Rob Godfrey - Change implementation of FieldTable
----
Modified : /incubator/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/exchange/HeadersBinding.java
Modified : /incubator/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/exchange/HeadersExchange.java
Modified : /incubator/qpid/trunk/qpid/java/broker/src/test/java/org/apache/qpid/server/exchange/HeadersBindingTest.java
Modified : /incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
Modified : /incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/message/AbstractJMSMessage.java
Modified : /incubator/qpid/trunk/qpid/java/client/src/test/java/org/apache/qpid/test/unit/message/StreamMessageTest.java
Added : /incubator/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/framing/AMQType.java
Added : /incubator/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/framing/AMQTypeMap.java
Added : /incubator/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/framing/AMQTypedValue.java
Modified : /incubator/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/framing/EncodingUtils.java
Modified : /incubator/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/framing/FieldTable.java
Modified : /incubator/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/framing/FieldTableFactory.java
Modified : /incubator/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/framing/JMSPropertyFieldTable.java
Deleted : /incubator/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/framing/PropertyFieldTable.java
Modified : /incubator/qpid/trunk/qpid/java/common/src/test/java/org/apache/qpid/framing/BasicContentHeaderPropertiesTest.java
Modified : /incubator/qpid/trunk/qpid/java/common/src/test/java/org/apache/qpid/framing/JMSPropertyFieldTableTest.java
Modified : /incubator/qpid/trunk/qpid/java/common/src/test/java/org/apache/qpid/framing/PropertyFieldTableTest.java
Modified : /incubator/qpid/trunk/qpid/java/systests/src/test/java/org/apache/qpid/server/exchange/AbstractHeadersExchangeTestBase.java
Modified : /incubator/qpid/trunk/qpid/java/systests/src/test/java/org/apache/qpid/server/exchange/ExchangeMBeanTest.java
Modified : /incubator/qpid/trunk/qpid/java/systests/src/test/java/org/apache/qpid/server/exchange/ReturnUnroutableMandatoryMessageTest.java




> Alter implementation of FieldTable to encapsualte each type in its own enum instance
> ------------------------------------------------------------------------------------
>
>                 Key: QPID-229
>                 URL: https://issues.apache.org/jira/browse/QPID-229
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Common
>            Reporter: Rob Godfrey
>            Priority: Minor
>         Attachments: QPID-229.patch
>
>
> After implementing the JMSMapMessage as a Stream Message, rather than a FieldTable, now implement FieldTable in a way that removes the need for it to pretend that it is a true Map.  Also encapsulate the behaviour of eaxch of the AMQ Types into an enum instance to take out the lengthy case statements in the code.
> As FieldTable is no longer a Map, some code in HeadersExchange also needs changin

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira