[GitHub] [ozone] swamirishi commented on a diff in pull request #3518: HDDS-6847. Audit for ALLOCATE_BLOCK should indicate number of allocated blocks

["swamirishi (via GitHub)" <gi...@apache.org>]

swamirishi commented on code in PR #3518:
URL: https://github.com/apache/ozone/pull/3518#discussion_r1090044397


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java:
##########
@@ -196,6 +196,16 @@ public List<AllocatedBlock> allocateBlock(
           blocks.add(block);

Review Comment:
   Yeah that is BlockManagerImpl.allocateBlock throws an exception when allocate block fails in the selected container. But if the container is null, a null is returned. Changes need to go in  SCMBlockProtocolServer to fail it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org