[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3187: it throw Exception "Must have one sharding with subquery" , the logic might be have problem

[GitBox <gi...@apache.org>]

terrymanu commented on issue #3187: it throw Exception "Must have one sharding with subquery" ,  the logic might be have problem 
URL: https://github.com/apache/incubator-shardingsphere/issues/3187#issuecomment-543086849
 
 
   Yes, here need to fix.
   Current state is subquery must have sharding value which is incorrect.
   
   We can consider about the rule like:
   
   1. If only one subquery's layer has table, just extract and rewrite this layer of subquery. This is the original logic.
   
   2. If more than one subquery's layers have tables, should judge whether single route, pass if yes, throw exception if no.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services