You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/04/28 23:06:57 UTC
[GitHub] flink pull request: [FLINK-3845] [gelly] Gelly allows duplicate ve...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1949
[FLINK-3845] [gelly] Gelly allows duplicate vertices in Graph.addVertices
Vertex sets are now merged with a cogroup so that a new Vertex is only added to the Graph when no existing Vertex exists with the same label.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3845_gelly_allows_duplicate_vertices_in_graph_addvertices
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1949
----
commit 51a4733d0a52e21093e79b326e521d386f11b95d
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-04-28T15:34:41Z
[FLINK-3845] [gelly] Gelly allows duplicate vertices in Graph.addVertices
Vertex sets are now merged with a cogroup so that a new Vertex is only
added to the Graph when no existing Vertex exists with the same label.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3845] [gelly] Gelly allows duplicate ve...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1949#discussion_r61685159
--- Diff: flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphMutationsITCase.java ---
@@ -32,6 +32,8 @@
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
+import static javafx.scene.input.KeyCode.L;
--- End diff --
This was added by mistake I suppose?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3845] [gelly] Gelly allows duplicate ve...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3845] [gelly] Gelly allows duplicate ve...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1949#issuecomment-215641753
I would add a test case to verify the fix here, too. Otherwise, +1 and thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3845] [gelly] Gelly allows duplicate ve...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1949#issuecomment-216287144
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3845] [gelly] Gelly allows duplicate ve...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1949#discussion_r61690685
--- Diff: flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphMutationsITCase.java ---
@@ -32,6 +32,8 @@
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
+import static javafx.scene.input.KeyCode.L;
--- End diff --
Yes, not sure where IntelliJ got that idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---