[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #8193: Introduce the Customized ALS Protocol for Satellite

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #8193:
URL: https://github.com/apache/skywalking/pull/8193#discussion_r757825904



##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/AccessLogServiceGRPCHandler.java
##########
@@ -105,7 +110,7 @@ public AccessLogServiceGRPCHandler(ModuleManager manager,
             public void onNext(StreamAccessLogsMessage message) {
                 HistogramMetrics.Timer timer = histogram.createTimer();
                 try {
-                    if (isFirst) {
+                    if (isFirst || (alwaysAnalyzeIdentity && message.getIdentifier() != null)) {

Review comment:
       You overlooked these:
   
   ```java
               for (ALSHTTPAnalysis analysis : envoyHTTPAnalysisList) {
                    role = analysis.identify(identifier, role);
               }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org