You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "porunov (via GitHub)" <gi...@apache.org> on 2026/06/29 10:25:16 UTC
[PR] Support Java 25 and Spark 4.1, raise minimum to Java 17 [tinkerpop]
porunov opened a new pull request, #3489:
URL: https://github.com/apache/tinkerpop/pull/3489
Modernizes TinkerPop 4.0 to build and run on Java 25 and upgrades the Spark OLAP integration to Spark 4.1. Because Spark 4 requires Java 17 as a minimum, the project-wide minimum Java version is raised from 11 to 17.
Java 25 support:
- Groovy 4.0.25 -> 4.0.32 (bundled ASM parses Java 25 bytecode)
- StringFactory: detect the Java 21+ lambda class name format ($$Lambda/)
- LambdaRestrictionStrategy: match "lambda" case-insensitively
- ImportGremlinPluginTest: account for Math.TAU added in Java 19
- gremlin-groovy: declare annotationProcessorPaths explicitly (JDK 23+ no longer runs classpath-discovered processors) and widen the javadoc groovy-stubs profile to all supported JDKs
- gremlin-console: apply the neo4j-gremlin --add-opens flags for JDK 17+
Dependency upgrades:
- Hadoop 3.4.2 -> 3.4.3 (uses the Subject.current()/callAs() replacement APIs, so hadoop-gremlin runs on Java 25)
- Spark 3.5.4 -> 4.1.2, which is Scala 2.13 only and the first Spark line to support Java 25. Switched spark-core_2.12 -> _2.13, ported the Scala 2.13 changes (JavaConversions -> CollectionConverters, WrappedArray -> immutable ArraySeq) and aligned Netty, jackson (via jackson-bom) and other transitive versions that Spark 4 requires
- Netty 4.1.125 -> 4.2.7 (required by Spark 4)
Java 17 baseline (breaking):
- enforcer requireJavaVersion [11,18) -> [17,26); compiler release 11 -> 17 (and gremlin-groovy/gremlin-annotations release 8 -> 17)
- build-test.yml: all jobs run on Java 17, plus a new Java 25 job; the Java 11 job is removed and coverage runs on the Java 17 job
- Dockerfiles and developer docs updated to Java 17
Validated with a full `mvn clean install` on both Java 17 and Java 25 (all JVM modules, including hadoop-gremlin and spark-gremlin).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Java 25 and Spark 4.1, raise minimum to Java 17 [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #3489:
URL: https://github.com/apache/tinkerpop/pull/3489#issuecomment-4896059287
I think we should also add a GitHub actions config for Java 21 as well, considering it is also an LTS. Would you be able to add that additional job?
VOTE +1 (pending Java 21 testing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Java 21/25 and Spark 4.1, raise minimum to Java 17 [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #3489:
URL: https://github.com/apache/tinkerpop/pull/3489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Java 21/25 and Spark 4.1, raise minimum to Java 17 [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #3489:
URL: https://github.com/apache/tinkerpop/pull/3489#issuecomment-4919097930
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Java 25 and Spark 4.1, raise minimum to Java 17 [tinkerpop]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3489:
URL: https://github.com/apache/tinkerpop/pull/3489#issuecomment-4831659228
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3489?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 75.84%. Comparing base ([`a28cd1f`](https://app.codecov.io/gh/apache/tinkerpop/commit/a28cd1f2f1f10c140030a56de44c5c6c045af5f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a665863`](https://app.codecov.io/gh/apache/tinkerpop/commit/a665863b19643974e9fe3d7a36320358a9b8800f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 161 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/tinkerpop/pull/3489?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...inkerpop/gremlin/structure/util/StringFactory.java](https://app.codecov.io/gh/apache/tinkerpop/pull/3489?src=pr&el=tree&filepath=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Fstructure%2Futil%2FStringFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvdXRpbC9TdHJpbmdGYWN0b3J5LmphdmE=) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/3489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3489 +/- ##
============================================
- Coverage 76.35% 75.84% -0.52%
- Complexity 13424 13686 +262
============================================
Files 1012 998 -14
Lines 60341 55690 -4651
Branches 7075 7231 +156
============================================
- Hits 46076 42239 -3837
+ Misses 11548 10851 -697
+ Partials 2717 2600 -117
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/tinkerpop/pull/3489?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Java 21/25 and Spark 4.1, raise minimum to Java 17 [tinkerpop]
Posted by "porunov (via GitHub)" <gi...@apache.org>.
porunov commented on PR #3489:
URL: https://github.com/apache/tinkerpop/pull/3489#issuecomment-4906846577
Thanks @Cole-Greer for the review! Both JDK 21 tests and the documentation updates were added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org