You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/23 07:55:38 UTC
[GitHub] [arrow-datafusion] silence-coding opened a new pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
silence-coding opened a new pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066
fix #2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1076746995
> It'll be better to add a test for the fix :)
I agree with @xudong963 -- can you please provide a test (both to demonstrate what is wrong and help ensure we don't break it again in the future).
Perhaps you can adapt the reproducer on https://github.com/apache/arrow-datafusion/issues/2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1079221667
Thanks again @silence-coding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb edited a comment on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1077891162
Sadly I think https://github.com/apache/arrow-datafusion/pull/2023 added 3.json already -- can you fix this PR to use the name `4.json`?
like:
```diff
--- a/datafusion/src/datasource/file_format/json.rs
+++ b/datafusion/src/datasource/file_format/json.rs
@@ -236,7 +236,7 @@ mod tests {
#[tokio::test]
async fn infer_schema_with_limit() {
- let filename = "tests/jsons/3.json";
+ let filename = "tests/jsons/4.json";
let format = JsonFormat::default()
.with_schema_infer_max_rec(Some(3));
let file_schema = format
diff --git a/datafusion/tests/jsons/3.json b/datafusion/tests/jsons/4.json
similarity index 100%
rename from datafusion/tests/jsons/3.json
rename to datafusion/tests/jsons/4.json
```
to resolve the conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1079221302
> I think we can open an issue to discuss the next version release.
I created https://github.com/apache/arrow-datafusion/issues/2095 to start this conversation -- @silence-coding it would be great to hear your perspective if you are thinking of a release directly from master, or a release that has only bug fixes, or something else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] silence-coding commented on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
silence-coding commented on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1077002017
@alamb @xudong963 That's my problem. I forgot to write test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1077891162
Sadly I think https://github.com/apache/arrow-datafusion/pull/2023 added 3.json already -- can you fix this PR to use the name `4.json`?
like:
```diff
--- a/datafusion/src/datasource/file_format/json.rs
+++ b/datafusion/src/datasource/file_format/json.rs
@@ -236,7 +236,7 @@ mod tests {
#[tokio::test]
async fn infer_schema_with_limit() {
- let filename = "tests/jsons/3.json";
+ let filename = "tests/jsons/4.json";
let format = JsonFormat::default()
.with_schema_infer_max_rec(Some(3));
let file_schema = format
diff --git a/datafusion/tests/jsons/3.json b/datafusion/tests/jsons/4.json
similarity index 100%
rename from datafusion/tests/jsons/3.json
rename to datafusion/tests/jsons/4.json
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] silence-coding commented on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
silence-coding commented on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1076112112
@alamb Please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] silence-coding commented on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
silence-coding commented on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1078619260
> Sadly I think #2023 added 3.json already -- can you fix this PR to use the name `4.json`?
>
> like:
>
> ```diff
> --- a/datafusion/src/datasource/file_format/json.rs
> +++ b/datafusion/src/datasource/file_format/json.rs
> @@ -236,7 +236,7 @@ mod tests {
>
> #[tokio::test]
> async fn infer_schema_with_limit() {
> - let filename = "tests/jsons/3.json";
> + let filename = "tests/jsons/4.json";
> let format = JsonFormat::default()
> .with_schema_infer_max_rec(Some(3));
> let file_schema = format
> diff --git a/datafusion/tests/jsons/3.json b/datafusion/tests/jsons/4.json
> similarity index 100%
> rename from datafusion/tests/jsons/3.json
> rename to datafusion/tests/jsons/4.json
> ```
>
> to resolve the conflict?
fix with schema_infer_limit.json
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb edited a comment on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1076746995
Thank you for the contribution @silence-coding
> It'll be better to add a test for the fix :)
I agree with @xudong963 -- can you please provide a test (both to demonstrate what is wrong and help ensure we don't break it again in the future)?
Perhaps you can adapt the reproducer on https://github.com/apache/arrow-datafusion/issues/2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] silence-coding commented on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
silence-coding commented on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1078715516
When will the next version be released?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb edited a comment on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1076746995
> It'll be better to add a test for the fix :)
I agree with @xudong963 -- can you please provide a test (both to demonstrate what is wrong and help ensure we don't break it again in the future)?
Perhaps you can adapt the reproducer on https://github.com/apache/arrow-datafusion/issues/2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] silence-coding edited a comment on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
silence-coding edited a comment on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1078619260
@alamb fix with schema_infer_limit.json
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on pull request #2066: fix issue#2058 file_format/json.rs attempt to subtract with overflow
Posted by GitBox <gi...@apache.org>.
xudong963 commented on pull request #2066:
URL: https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1078726733
> When will the next version be released?
I think we can open an issue to discuss the next version release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org