You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/04/04 11:14:51 UTC

[GitHub] [systemds] Baunsgaard opened a new pull request, #1575: [SYSTEMDS-3343] Boolean Arguments in GridSearch

Baunsgaard opened a new pull request, #1575:
URL: https://github.com/apache/systemds/pull/1575

   Boolean arguments in lists evaluate to false behind eval calls.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1575: [SYSTEMDS-3343] Boolean Arguments in GridSearch

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on PR #1575:
URL: https://github.com/apache/systemds/pull/1575#issuecomment-1087507261

   This PR contains some tests that currently incorrectly map boolean arguments to the functions through eval calls.
   I hypothesize that it has to do with conversion to scalars somewhere for our boolean arguments.
   The evaluation is correct if the boolean arguments are part of the grid, but not if they are set to default values.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1575: [SYSTEMDS-3343] Boolean Arguments in GridSearch

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on PR #1575:
URL: https://github.com/apache/systemds/pull/1575#issuecomment-1128743278

   My tests here, might be different since i here call methods that have no default value,
   but instead my default value is set inside the lists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] asfgit closed pull request #1575: [SYSTEMDS-3343] Boolean Arguments in GridSearch

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1575: [SYSTEMDS-3343] Boolean Arguments in GridSearch
URL: https://github.com/apache/systemds/pull/1575


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1575: [SYSTEMDS-3343] Boolean Arguments in GridSearch

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on PR #1575:
URL: https://github.com/apache/systemds/pull/1575#issuecomment-1128725689

   Tests are in 
   src/test/java/org/apache/sysds/test/functions/mlcontext/MLContextTest.java
   
   - testExecuteEvalGridSearchNoDefault
   - testExecuteEvalGridSearchWithDefault
   - testExecuteEvalGridSearchWithTwoDefault
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1575: [SYSTEMDS-3343] Boolean Arguments in GridSearch

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on PR #1575:
URL: https://github.com/apache/systemds/pull/1575#issuecomment-1128724294

   @mboehm7 
   It seems like your fix to boolean arguments ( a0987e536a2be71d16d64ac64e9873206083e49b ) with defaults did not fix the issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] mboehm7 commented on pull request #1575: [SYSTEMDS-3343] Boolean Arguments in GridSearch

Posted by GitBox <gi...@apache.org>.
mboehm7 commented on PR #1575:
URL: https://github.com/apache/systemds/pull/1575#issuecomment-1128729783

   I did not try out this PR here yet, but there was no issue with boolean defaults. My recent changes first introduced that we support defaults in eval calls at all. In the past, gridSearch simply fixed verbose=FALSE but I added tests which now check that gridSearch works correctly for both verbose configurations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org