You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/02 11:08:40 UTC
[GitHub] [airflow] potiuk commented on issue #5022: [AIRFLOW-4197] Remove
Python2 CI jobs
potiuk commented on issue #5022: [AIRFLOW-4197] Remove Python2 CI jobs
URL: https://github.com/apache/airflow/pull/5022#issuecomment-478949332
In the past I had quite a few things that did not work on 3.5 while they were working on 3.6. But we might be surprised by some incompatibilities. I'd say if we say we support 3.5, 3.6, 3.7 we should run tests on all of them. Maybe we should drop 3.5 compatibility officially ;) ?
Here are some examples of nasty incompatibilities I encountered while working on Airflow:
* There is different sorting order of dictionary keys (https://stackoverflow.com/a/40007169/516701) (it's an implementation detail in 3.6 but as of 3.7 you can start relying on it. ). I saw code that implicitly relied on maintaining inserting order - which would fail on 3.5, while it would work differently on 3.6 and 3.7. So I think 3.5 is a must. I caught it during code rewiew luckily, and we added unit test for it.
* 3.7 has new reserved words (async/await) which is all too easy to be used as variable name. It's been a problem in the past in airflow, and might went'= unnoticed if we do not run 3.7 tests.
* I had a code (related to json.decoding() of subprocess command output) that worked on 2.7 AND 3.6 but did not work on 3.5 (!!!!). It was a bit surprising but you can find details in https://github.com/apache/airflow/pull/4254/commits/22bea285c2cace4a60b96fca4ad077cc91124907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services