You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Paul Rogers (Code Review)" <ge...@cloudera.org> on 2018/11/09 19:14:26 UTC

[Impala-ASF-CR] IMPALA-7841: Refactor QueryStmt, etc. for easier debugging

Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11915


Change subject: IMPALA-7841: Refactor QueryStmt, etc. for easier debugging
......................................................................

IMPALA-7841: Refactor QueryStmt, etc. for easier debugging

Builds on IMPALA-7808 with several additional refactorings:

* IMPALA-7808 minimized code changes. This change cleans up the
  new functions, removing if's and merging the "aggregation"
  function with the body of the new analyze() function.
* Creates a new "QueryAnalyzer" class in the QueryStmt class.
* Changed the SelectStmt's SelectAnalyzer to extend the new
  QueryAnalyzer. This allows removing some "analyzer"
  parameters.
* Played the same trick for other classes that extend
  QueryStmt.

This is all refactoring: there is no functional change.

Testing: Reran existing tests to ensure that functionality
remained unchanged.

Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CollectionTableRef.java
M fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java
M fe/src/main/java/org/apache/impala/analysis/QueryStmt.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/main/java/org/apache/impala/analysis/Subquery.java
M fe/src/main/java/org/apache/impala/analysis/UnionStmt.java
M fe/src/main/java/org/apache/impala/analysis/WithClause.java
8 files changed, 218 insertions(+), 202 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/11915/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
Gerrit-Change-Number: 11915
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 )

Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
Gerrit-Change-Number: 11915
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Jan 2019 01:12:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.

Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 )

Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
Gerrit-Change-Number: 11915
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jan 2019 21:03:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 )

Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3666/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
Gerrit-Change-Number: 11915
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jan 2019 21:03:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

Posted by "Paul Rogers (Code Review)" <ge...@cloudera.org>.

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 )

Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging
......................................................................


Patch Set 2:

Reduced the scope of the change for easier review. Will push the QueryStmt and related changes as a separate patch after this one. This one now just moves some code around in SelectStmt and fixes one name and removes one unneeded argument.


-- 
To view, visit http://gerrit.cloudera.org:8080/11915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
Gerrit-Change-Number: 11915
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Dec 2018 22:06:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 )

Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1866/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4fe3d3a1ab3170e294714dab066d40d169eff1
Gerrit-Change-Number: 11915
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jan 2019 21:56:10 +0000
Gerrit-HasComments: No