You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2014/09/25 04:59:32 UTC

git commit: Don't assign to param (easier to debug too).

Repository: logging-log4j2
Updated Branches:
  refs/heads/master 6a5fc0250 -> 0d184208f


Don't assign to param (easier to debug too).

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/0d184208
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/0d184208
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/0d184208

Branch: refs/heads/master
Commit: 0d184208fe97e8d039c073eed2f70f2d67d9af3f
Parents: 6a5fc02
Author: Gary Gregory <ga...@gmail.com>
Authored: Wed Sep 24 22:59:29 2014 -0400
Committer: Gary Gregory <ga...@gmail.com>
Committed: Wed Sep 24 22:59:29 2014 -0400

----------------------------------------------------------------------
 .../java/org/apache/logging/log4j/core/pattern/PatternParser.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/0d184208/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java
index 510498e..7b054c5 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/PatternParser.java
@@ -251,7 +251,8 @@ public final class PatternParser {
      *            array to receive extracted options
      * @return position in pattern after options.
      */
-    private static int extractOptions(final String pattern, int i, final List<String> options) {
+    private static int extractOptions(final String pattern, final int start, final List<String> options) {
+        int i = start;
         while (i < pattern.length() && pattern.charAt(i) == '{') {
             final int begin = i++;
             int end;