You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/02/12 07:52:59 UTC
[isis] 01/01: ISIS-2502: housekeeping
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch ISIS-2502-ex.recog
in repository https://gitbox.apache.org/repos/asf/isis.git
commit e1b9e2eeb889a05c766f11c2d8a3a524ebded731
Author: Andi Huber <ah...@apache.org>
AuthorDate: Fri Feb 12 08:52:47 2021 +0100
ISIS-2502: housekeeping
---
.../java/org/apache/isis/applib/services/exceprecog/Category.java | 2 ++
.../java/org/apache/isis/applib/services/exceprecog/Recognition.java | 4 ++--
.../isis/testdomain/persistence/jdo/_JdoExceptionTranslator.java | 2 +-
.../isis/testdomain/persistence/jpa/_JpaExceptionTranslator.java | 2 +-
4 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/exceprecog/Category.java b/api/applib/src/main/java/org/apache/isis/applib/services/exceprecog/Category.java
index 35531df..a3afc14 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/exceprecog/Category.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/exceprecog/Category.java
@@ -6,6 +6,8 @@ import lombok.RequiredArgsConstructor;
/**
* Categorises each exception that has been recognised, as per
* {@link Recognition#getCategory()}.
+ *
+ * @since 1.x {@index}
*/
@RequiredArgsConstructor
public enum Category {
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/exceprecog/Recognition.java b/api/applib/src/main/java/org/apache/isis/applib/services/exceprecog/Recognition.java
index d345505..ae39585 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/exceprecog/Recognition.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/exceprecog/Recognition.java
@@ -17,6 +17,8 @@ import lombok.val;
* <p>
* Returned by {@link ExceptionRecognizer#recognize(Throwable)} when the
* exception recognizer has recognised the exception
+ *
+ * @since 1.x {@index}
*/
@Value
public class Recognition {
@@ -81,7 +83,6 @@ public class Recognition {
* {@link TranslationService}..
*
* @param translationService
- * @return
*/
public String toMessage(@Nullable TranslationService translationService) {
@@ -98,7 +99,6 @@ public class Recognition {
* {@link TranslationService}..
*
* @param translationService
- * @return
*/
public String toMessageNoCategory(@Nullable TranslationService translationService) {
diff --git a/regressiontests/stable/src/test/java/org/apache/isis/testdomain/persistence/jdo/_JdoExceptionTranslator.java b/regressiontests/stable/src/test/java/org/apache/isis/testdomain/persistence/jdo/_JdoExceptionTranslator.java
index 745bd72..61f5a70 100644
--- a/regressiontests/stable/src/test/java/org/apache/isis/testdomain/persistence/jdo/_JdoExceptionTranslator.java
+++ b/regressiontests/stable/src/test/java/org/apache/isis/testdomain/persistence/jdo/_JdoExceptionTranslator.java
@@ -32,7 +32,7 @@ import org.apache.isis.persistence.jdo.spring.integration.JdoTransactionManager;
final class _JdoExceptionTranslator {
- //TODO[2502] if only we found a way to have this code run at a lower level already
+ // not used, but maybe keep for debugging purposes
static DataAccessException translate(Throwable failure, JdoTransactionManager txManager) {
return (DataAccessException) Result.failure(failure)
diff --git a/regressiontests/stable/src/test/java/org/apache/isis/testdomain/persistence/jpa/_JpaExceptionTranslator.java b/regressiontests/stable/src/test/java/org/apache/isis/testdomain/persistence/jpa/_JpaExceptionTranslator.java
index fb9c699..0d99284 100644
--- a/regressiontests/stable/src/test/java/org/apache/isis/testdomain/persistence/jpa/_JpaExceptionTranslator.java
+++ b/regressiontests/stable/src/test/java/org/apache/isis/testdomain/persistence/jpa/_JpaExceptionTranslator.java
@@ -27,7 +27,7 @@ import org.apache.isis.commons.internal.exceptions._Exceptions;
final class _JpaExceptionTranslator {
- //TODO[2502] if only we found a way to have this code run at a lower level already
+ // not used, but maybe keep for debugging purposes
static DataAccessException translate(Throwable failure, JpaTransactionManager txManager) {
return (DataAccessException) Result.failure(failure)