Re: [PR] KAFKA-18896 add KIP-877 support for Login [kafka]

["mimaison (via GitHub)" <gi...@apache.org>]

mimaison commented on PR #19527:
URL: https://github.com/apache/kafka/pull/19527#issuecomment-3852158247

   > The `InterBrokerCustomLogin` plugin is sometimes registered on the `ConnectionMode#SERVER` side, so its tag may contain server tag information.
   > 
   > ```
   > Checking metric: MetricName [name=monitorable-inter-broker-custom-login-name, group=plugins, description=monitorable-inter-broker-custom-login-description, tags={config=sasl.login.class, class=InterBrokerCustomLogin, listener=CONTROLLER, mechanism=PLAIN}]
   > ```
   > 
   > Since we cannot guarantee which component registers this plugin first, we may need to use an `OR` condition to validate that at least one tag condition is met.
   
   I'm not sure I understand exactly what you mean. Which components are registering the plugin? Are they all using the same Plugin instance? If so, we should guarantee which component does it so the metric name is consistent and does not change across broker restart. If not, we should get one metric series per Plugin instance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org