[GitHub] [superset] stephenLYZ commented on a change in pull request #18950: chore: Change Sort by and Sort descending controls for Time-series Bar Chart

[GitBox <gi...@apache.org>]

stephenLYZ commented on a change in pull request #18950:
URL: https://github.com/apache/superset/pull/18950#discussion_r817659926



##########
File path: superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
##########
@@ -508,6 +517,7 @@ const sharedControls = {
   limit,
   timeseries_limit_metric: enableExploreDnd ? dnd_sort_by : sort_by,
   orderby: enableExploreDnd ? dnd_sort_by : sort_by,
+  order_desc,

Review comment:
       Can we replace all the chart's order desc with this? Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org