[GitHub] [echarts] pissang commented on a change in pull request #15589: fix(polar): wrong sector clockwise when previous data is 0 #15517

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #15589:
URL: https://github.com/apache/echarts/pull/15589#discussion_r700694369



##########
File path: src/chart/bar/BarView.ts
##########
@@ -750,7 +750,7 @@ const elementCreator: {
         // direction. Notice that if clockwise is true (by default), the sector
         // will always draw clockwisely, no matter whether endAngle is greater
         // or less than startAngle.
-        const clockwise = layout.startAngle < layout.endAngle;
+        const clockwise = layout.startAngle <= layout.endAngle;

Review comment:
       It may still have issue when `angleAxis.clockwise` is set to `false`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org