You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/03/22 17:29:05 UTC
[GitHub] activemq-artemis pull request #1971: ARTEMIS-1766 - Persist LastValue queue ...
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1971
ARTEMIS-1766 - Persist LastValue queue config in bindings.
Added Integration tests for the issue.
Add lastvalue to the queue bindings that get persisted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1766
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1971.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1971
----
commit c87d46d42bfe74ff6738e13bc63ce1edac68c79d
Author: Michael André Pearce <mi...@...>
Date: 2018-03-22T17:22:54Z
ARTEMIS-1766 - Persist LastValue queue config in bindings.
Added Integration tests for the issue.
Add lastvalue to the queue bindings that get persisted.
----
---
[GitHub] activemq-artemis issue #1971: ARTEMIS-1766 - Persist LastValue queue config ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1971
@michaelandrepearce the failure on compatibility test seems real
---
[GitHub] activemq-artemis issue #1971: ARTEMIS-1766 - Persist LastValue queue config ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1971
@michaelandrepearce yeah. unrelated.. I fixed the intermittent failure... will merge it soon.
if you're curious to see if it fixed.. rebase this PR and push -f.
I will merge this soon.
---
[GitHub] activemq-artemis pull request #1971: ARTEMIS-1766 - Persist LastValue queue ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1971
---
[GitHub] activemq-artemis issue #1971: ARTEMIS-1766 - Persist LastValue queue config ...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1971
@clebertsuconic I think it’s unrelated. And simply pr build issue.
I ran tests all locally fine.
---
[GitHub] activemq-artemis issue #1971: ARTEMIS-1766 - Persist LastValue queue config ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1971
hmmmm... I'm not so sure... hang on
---