You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/02 20:21:09 UTC
[GitHub] [airflow] XD-DENG opened a new pull request #14567: Suppress LOG/WARNING for a few tasks CLI for better CLI experience
XD-DENG opened a new pull request #14567:
URL: https://github.com/apache/airflow/pull/14567
For `state`/`list`/`render`, more likely users would like to rely on the CLI output for some work, and the Python LOG/WARNING prints cause inconvenience.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #14567: Suppress LOG/WARNING for a few tasks CLI for better CLI experience
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #14567:
URL: https://github.com/apache/airflow/pull/14567#issuecomment-789187603
For milestone, I think it should be at least partially depending on https://github.com/apache/airflow/pull/13180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14567: Suppress LOG/WARNING for a few tasks CLI for better CLI experience
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14567:
URL: https://github.com/apache/airflow/pull/14567#issuecomment-789294450
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #14567: Suppress LOG/WARNING for a few tasks CLI for better CLI experience
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #14567:
URL: https://github.com/apache/airflow/pull/14567#issuecomment-789288490
Some tests are failing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #14567: Suppress LOG/WARNING for a few tasks CLI for better CLI experience
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #14567:
URL: https://github.com/apache/airflow/pull/14567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14567: Suppress LOG/WARNING for a few tasks CLI for better CLI experience
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14567:
URL: https://github.com/apache/airflow/pull/14567#issuecomment-789288490
tests are failing though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #14567: Suppress LOG/WARNING for a few tasks CLI for better CLI experience
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #14567:
URL: https://github.com/apache/airflow/pull/14567#issuecomment-789642726
Thanks @kaxil .
Fixed in https://github.com/apache/airflow/pull/14567/commits/bbee3e7330965b3c9959b1fb79001ee9b6b0b955 and the CI is green now. Gonna merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org