[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #797: [#796] bug:fix the issues of MetricReporter

["xianjingfeng (via GitHub)" <gi...@apache.org>]

xianjingfeng commented on code in PR #797:
URL: https://github.com/apache/incubator-uniffle/pull/797#discussion_r1158379948


##########
common/src/main/java/org/apache/uniffle/common/metrics/MetricReporterFactory.java:
##########
@@ -33,7 +33,7 @@ public static MetricReporter getMetricReporter(RssConf conf, String instanceId)
     }
     Class<?> klass = Class.forName(name);
     Constructor<?> constructor;
-    constructor = klass.getConstructor(conf.getClass(), instanceId.getClass());
+    constructor = klass.getConstructor(RssConf.class, String.class);

Review Comment:
   In the origin code, if `conf` is an instance of subclass of RssConf, exception will be thrown.  #796 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org