You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Victor Antonovich (JIRA)" <ji...@apache.org> on 2010/09/29 15:27:32 UTC
[jira] Created: (FELIX-2635) PluginHolder.setServletContext() must
nullify servlet context after plugins destroying
PluginHolder.setServletContext() must nullify servlet context after plugins destroying
---------------------------------------------------------------------------------------
Key: FELIX-2635
URL: https://issues.apache.org/jira/browse/FELIX-2635
Project: Felix
Issue Type: Bug
Components: Web Console
Affects Versions: webconsole-3.1.4
Reporter: Victor Antonovich
Java Servlet Specification Version 2.5, SRV.15.2.12.1 says: "All servlets and filters have been destroy()ed before any ServletContextListeners are notified of context destruction". But current PluginHolder.setServletContext() implementation calls destroy() method of plugins after destroying (nullifying) of ServletContext. This causes NPE in plugins trying to access to ServletContext in their destroy() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2635) PluginHolder.setServletContext() must
nullify servlet context after plugins destroying
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-2635:
-------------------------------------
Affects Version/s: webconsole-3.1.2
(was: webconsole-3.1.4)
> PluginHolder.setServletContext() must nullify servlet context after plugins destroying
> ---------------------------------------------------------------------------------------
>
> Key: FELIX-2635
> URL: https://issues.apache.org/jira/browse/FELIX-2635
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Victor Antonovich
> Assignee: Felix Meschberger
> Fix For: webconsole-3.1.4
>
> Attachments: webconsole_set_servlet_context.patch
>
>
> Java Servlet Specification Version 2.5, SRV.15.2.12.1 says: "All servlets and filters have been destroy()ed before any ServletContextListeners are notified of context destruction". But current PluginHolder.setServletContext() implementation calls destroy() method of plugins after destroying (nullifying) of ServletContext. This causes NPE in plugins trying to access to ServletContext in their destroy() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-2635) PluginHolder.setServletContext() must
nullify servlet context after plugins destroying
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed FELIX-2635.
------------------------------------
Close after release
> PluginHolder.setServletContext() must nullify servlet context after plugins destroying
> ---------------------------------------------------------------------------------------
>
> Key: FELIX-2635
> URL: https://issues.apache.org/jira/browse/FELIX-2635
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Victor Antonovich
> Assignee: Felix Meschberger
> Fix For: webconsole-3.1.6
>
> Attachments: webconsole_set_servlet_context.patch
>
>
> Java Servlet Specification Version 2.5, SRV.15.2.12.1 says: "All servlets and filters have been destroy()ed before any ServletContextListeners are notified of context destruction". But current PluginHolder.setServletContext() implementation calls destroy() method of plugins after destroying (nullifying) of ServletContext. This causes NPE in plugins trying to access to ServletContext in their destroy() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-2635) PluginHolder.setServletContext() must
nullify servlet context after plugins destroying
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned FELIX-2635:
----------------------------------------
Assignee: Felix Meschberger
> PluginHolder.setServletContext() must nullify servlet context after plugins destroying
> ---------------------------------------------------------------------------------------
>
> Key: FELIX-2635
> URL: https://issues.apache.org/jira/browse/FELIX-2635
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.4
> Reporter: Victor Antonovich
> Assignee: Felix Meschberger
> Attachments: webconsole_set_servlet_context.patch
>
>
> Java Servlet Specification Version 2.5, SRV.15.2.12.1 says: "All servlets and filters have been destroy()ed before any ServletContextListeners are notified of context destruction". But current PluginHolder.setServletContext() implementation calls destroy() method of plugins after destroying (nullifying) of ServletContext. This causes NPE in plugins trying to access to ServletContext in their destroy() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-2635) PluginHolder.setServletContext() must
nullify servlet context after plugins destroying
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved FELIX-2635.
--------------------------------------
Fix Version/s: webconsole-3.1.4
Resolution: Fixed
Good catch ! Thanks for providing the patch.
I have applied it in Rev. 1002635 with a minor modification: Instead of assigning the parameter value "null" is assigned to make the intent clear and added try-catch around the destroy calls.
> PluginHolder.setServletContext() must nullify servlet context after plugins destroying
> ---------------------------------------------------------------------------------------
>
> Key: FELIX-2635
> URL: https://issues.apache.org/jira/browse/FELIX-2635
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.4
> Reporter: Victor Antonovich
> Assignee: Felix Meschberger
> Fix For: webconsole-3.1.4
>
> Attachments: webconsole_set_servlet_context.patch
>
>
> Java Servlet Specification Version 2.5, SRV.15.2.12.1 says: "All servlets and filters have been destroy()ed before any ServletContextListeners are notified of context destruction". But current PluginHolder.setServletContext() implementation calls destroy() method of plugins after destroying (nullifying) of ServletContext. This causes NPE in plugins trying to access to ServletContext in their destroy() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2635) PluginHolder.setServletContext() must
nullify servlet context after plugins destroying
Posted by "Victor Antonovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Victor Antonovich updated FELIX-2635:
-------------------------------------
Attachment: webconsole_set_servlet_context.patch
Proposed patch attached.
> PluginHolder.setServletContext() must nullify servlet context after plugins destroying
> ---------------------------------------------------------------------------------------
>
> Key: FELIX-2635
> URL: https://issues.apache.org/jira/browse/FELIX-2635
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.4
> Reporter: Victor Antonovich
> Attachments: webconsole_set_servlet_context.patch
>
>
> Java Servlet Specification Version 2.5, SRV.15.2.12.1 says: "All servlets and filters have been destroy()ed before any ServletContextListeners are notified of context destruction". But current PluginHolder.setServletContext() implementation calls destroy() method of plugins after destroying (nullifying) of ServletContext. This causes NPE in plugins trying to access to ServletContext in their destroy() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.