You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/03/10 20:09:19 UTC
[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4479:
/deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
ZugNZwang opened a new issue #4479: /deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
URL: https://github.com/apache/trafficcontrol/issues/4479
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
<!--
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- (check all that apply with "[x]") -->
<!--- security vulnerability (STOP!! - see above)-->
- [X] bug report
- [ ] new feature / enhancement request
- [X] improvement request (usability, performance, tech debt, etc.)
- [ ] other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- (check all that apply with "[x]") -->
- [ ] CDN in a Box
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Control Client
- [ ] Traffic Monitor
- [X] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] unknown
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
When making a `POST` request to `/deliveryservices/sslkeys/generate/letsencrypt` the user is allowed to input any value for the `cdn`, `key`, and `deliverservice` keys, even if the cdn, deliveryservice or key doesn't exist. The response returned is:
```json
HTTP/1.1 200 OK
{
"alerts": [
{
"text": "Beginning async call to Let's Encrypt for doesntexist. This may take a few minutes.",
"level": "info"
}
]
}
```
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
Response returned should be one of the following:
```json
HTTP/1.1 404 Not Found
{
"alerts": [
{
"text": "cdn not found",
"level": "error"
}
]
}
```
OR
```json
HTTP/1.1 404 Not Found
{
"alerts": [
{
"text": "deliveryservice not found",
"level": "error"
}
]
}
```
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
The error logs show:
`ERROR: letsencryptcert.go:187: ...: no DS with name doesntexist`
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4479:
/deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4479: /deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
URL: https://github.com/apache/trafficcontrol/issues/4479#issuecomment-597332624
if you put in a valid DS, does it check tenancy on the DS?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4479:
/deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4479: /deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
URL: https://github.com/apache/trafficcontrol/issues/4479#issuecomment-597833428
bumping this to major due to the lack of tenancy checking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ZugNZwang commented on issue #4479:
/deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
Posted by GitBox <gi...@apache.org>.
ZugNZwang commented on issue #4479: /deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
URL: https://github.com/apache/trafficcontrol/issues/4479#issuecomment-598841749
I think there should also be a check that the deliveryservice actually belongs to the cdn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ZugNZwang commented on issue #4479:
/deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
Posted by GitBox <gi...@apache.org>.
ZugNZwang commented on issue #4479: /deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
URL: https://github.com/apache/trafficcontrol/issues/4479#issuecomment-597334359
Doesn't check tenancy either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 closed issue #4479:
/deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
Posted by GitBox <gi...@apache.org>.
ocket8888 closed issue #4479: /deliveryservices/sslkeys/generate/letsencrypt doesn't perform checks
URL: https://github.com/apache/trafficcontrol/issues/4479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services