You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/18 19:00:33 UTC
[GitHub] [netbeans] Chris2011 opened a new pull request, #4653: Change class=myclass to .myclass and id=myid to #id to reduce noise
Chris2011 opened a new pull request, #4653:
URL: https://github.com/apache/netbeans/pull/4653
and make it cleaner and shorter
Inside the navigator for HTML files you see the elements with their IDs and Classes. NetBeans showed them as id=... and class=... ... .... We don't need this that long. Web developers just know the CSS selectors which are `#` for IDs and `.` for Classes. So I changed those 3 things:
* Changed `div id=myid` to `div #myid`
* Changed `div class=myclass` to `div .myclass`
* Changed `div class=my multi class` to `div .my.multi.class`
Before:
After:
Also, if you want, I can add an option for this but IMHO we don't need one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1250766805
> Ah, I see. OK :) You should write the URL for the documentation about it. Thanks!
What do you mean with the URL for documentation? You mean I should update a documentation in NetBeans somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1264475717
Here is a sample that might come from reality (we have several similar examples in our codebase):
Before:
After:
While I admit, that the original rendering is not optimal, from my perspective we gain little and reduce the usability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a diff in pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
junichi11 commented on code in PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#discussion_r974059563
##########
ide/html.editor/src/org/netbeans/modules/html/editor/gsf/HtmlStructureItem.java:
##########
@@ -91,13 +91,13 @@ public String getSortText() {
public String getHtml(HtmlFormatter formatter) {
formatter.appendHtml(getName());
if (idAttributeValue != null) {
- formatter.appendHtml(" <font color=808080>id=");
+ formatter.appendHtml(" <font color=808080>#");
formatter.appendText(idAttributeValue);
formatter.appendHtml("</font>"); //NOI18N
}
if (classAttributeValue != null) {
- formatter.appendHtml(" <font color=808080>class=");
- formatter.appendText(classAttributeValue);
+ formatter.appendHtml(" <font color=808080>.");
+ formatter.appendText(classAttributeValue.replace(" ", "."));
formatter.appendHtml("</font>"); //NOI18N
Review Comment:
L.99 and 100.
(Strings that we don't want to translate.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1257284418
@matthiasblaesing I added a method to remove the generic @@@ pattern, add . and join them all together.
I tested with this tags:
```html
<div style="height:50px" aria-hidden="true" class="wp-block-spacer "></div> <!-- Output: div.wp-block-spacer -->
<div style="height:50px" aria-hidden="true" class=" wp-block-spacer "></div> <!-- Output: div.wp-block-spacer -->
<h1 class="<?=$headerclass?> <?=$additionalclasses?>"></h1> <!-- Output: h1 -->
<h1 class="<?=$headerclass?> <?=$additionalclasses?>"></h1> <!-- Output: h1 -->
<h1 class="test <?=$additionalclasses?> tester"></h1> <!-- Output: h1.test.tester -->
<h1 class="test {{smth}} tester"></h1> <!-- Output: h1.test.{{smth}}.tester -->
<h1 class="test <whatever> tester"></h1> <!-- Output: h1.test.<whatever>.tester -->
```
Yes there probably more syntaxes as you already mentioned. I also tested JSF and JSP but the result seems okish for me. It was not ideal before and this is not what I wanted to change. This should be another topic IMHO.
Please lemme know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1250631924
The `.my.multi.class` represents the same CSS selector for this tag with multi classes. Showing `.my .multi .class` is a whole different selector. I also think about to remove the space between the tag and the classes/id. I don't want to show developers smth which is not 1to1 representation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1251453548
All of these examples could be valid, if NetBeans would handle the parsing and interpreting the languages to know the correct classes. With this example `class="myclass <?php echo 'test'; ?>"` the navigator shows this: `div.myclass@@@` old one: `div class=myclass @@@` so guess this will also be the thing for JSF and JSP. So dynamically added classes/ids are always a problem but this shouldn't be part of the navigator at all. Should it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1251460615
Yes I agree, that it already looks broken. That does not change my opinion about the change. I suspect somewhere in the HTML Support some intelligence detects external languages and replaces them with a filler. But what happens when you switch to an unsupported language (PHP with square brackets instead of curly ones?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a diff in pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
junichi11 commented on code in PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#discussion_r974057356
##########
ide/html.editor/src/org/netbeans/modules/html/editor/gsf/HtmlStructureItem.java:
##########
@@ -91,13 +91,13 @@ public String getSortText() {
public String getHtml(HtmlFormatter formatter) {
formatter.appendHtml(getName());
if (idAttributeValue != null) {
- formatter.appendHtml(" <font color=808080>id=");
+ formatter.appendHtml(" <font color=808080>#");
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1264512739
Yeah maybe, so maybe we should change this to a discussion. Will have a look into WebStorm. I know how VS Code does it, and it is similar to my solution: `.{{.user.?.user.:.'smth'.}}` So yes I aggree that it is not optimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a diff in pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
junichi11 commented on code in PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#discussion_r974024367
##########
ide/html.editor/src/org/netbeans/modules/html/editor/gsf/HtmlStructureItem.java:
##########
@@ -91,13 +91,13 @@ public String getSortText() {
public String getHtml(HtmlFormatter formatter) {
formatter.appendHtml(getName());
if (idAttributeValue != null) {
- formatter.appendHtml(" <font color=808080>id=");
+ formatter.appendHtml(" <font color=808080>#");
Review Comment:
Nitpic: should add `NOI18N` like the below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on a diff in pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on code in PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#discussion_r974028187
##########
ide/html.editor/src/org/netbeans/modules/html/editor/gsf/HtmlStructureItem.java:
##########
@@ -91,13 +91,13 @@ public String getSortText() {
public String getHtml(HtmlFormatter formatter) {
formatter.appendHtml(getName());
if (idAttributeValue != null) {
- formatter.appendHtml(" <font color=808080>id=");
+ formatter.appendHtml(" <font color=808080>#");
Review Comment:
To Line 94? Will do. Thx.
##########
ide/html.editor/src/org/netbeans/modules/html/editor/gsf/HtmlStructureItem.java:
##########
@@ -91,13 +91,13 @@ public String getSortText() {
public String getHtml(HtmlFormatter formatter) {
formatter.appendHtml(getName());
if (idAttributeValue != null) {
- formatter.appendHtml(" <font color=808080>id=");
+ formatter.appendHtml(" <font color=808080>#");
formatter.appendText(idAttributeValue);
formatter.appendHtml("</font>"); //NOI18N
}
if (classAttributeValue != null) {
- formatter.appendHtml(" <font color=808080>class=");
- formatter.appendText(classAttributeValue);
+ formatter.appendHtml(" <font color=808080>.");
+ formatter.appendText(classAttributeValue.replace(" ", "."));
formatter.appendHtml("</font>"); //NOI18N
Review Comment:
To Line 99? Will do. Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
junichi11 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1250411472
I prefer `div .my .multi .class` than `div .my.multi.class`. (Each class is hard to see...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1250883834
Ahh ok, yeah thx for the info. Can add this as a comment :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a diff in pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
junichi11 commented on code in PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#discussion_r974025893
##########
ide/html.editor/src/org/netbeans/modules/html/editor/gsf/HtmlStructureItem.java:
##########
@@ -91,13 +91,13 @@ public String getSortText() {
public String getHtml(HtmlFormatter formatter) {
formatter.appendHtml(getName());
if (idAttributeValue != null) {
- formatter.appendHtml(" <font color=808080>id=");
+ formatter.appendHtml(" <font color=808080>#");
formatter.appendText(idAttributeValue);
formatter.appendHtml("</font>"); //NOI18N
}
if (classAttributeValue != null) {
- formatter.appendHtml(" <font color=808080>class=");
- formatter.appendText(classAttributeValue);
+ formatter.appendHtml(" <font color=808080>.");
+ formatter.appendText(classAttributeValue.replace(" ", "."));
formatter.appendHtml("</font>"); //NOI18N
Review Comment:
Nitpick: `NOI18N`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1251467389
VS Code shows not @@@ it just removes it or not handle it. How PHPStorm or WebStorm handles it, I don't know it yet, but can check this to get an idea what they do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
junichi11 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1250752538
Ah, I see. OK :)
You should write the URL for the documentation about it.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1293997525
> What about make the shortening for just simple cases - keyword-like classes and IDs ? This should work OK for web content writer case that does not use templating (that) much
What do you think how the solution will look like? Just remove all what is not simple string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a diff in pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
junichi11 commented on code in PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#discussion_r974024367
##########
ide/html.editor/src/org/netbeans/modules/html/editor/gsf/HtmlStructureItem.java:
##########
@@ -91,13 +91,13 @@ public String getSortText() {
public String getHtml(HtmlFormatter formatter) {
formatter.appendHtml(getName());
if (idAttributeValue != null) {
- formatter.appendHtml(" <font color=808080>id=");
+ formatter.appendHtml(" <font color=808080>#");
Review Comment:
Nitpick: should add `NOI18N` like the below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
junichi11 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1250808888
> You mean I should update a documentation in NetBeans somewhere?
No. I meant the documentation of CSS/HTML.
e.g. somewhere on https://developer.mozilla.org/en-US/docs/Web/CSS
Maybe, class selector part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4653: Change HTML NavigatorStructureItem class=myclass to .myclass and id=myid to #id to reduce noise
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4653:
URL: https://github.com/apache/netbeans/pull/4653#issuecomment-1251466346
Ok, lemme find a way to handle this. As I tested it with this php example, the output here is `@@@` I will check the sources further whether they are differences and if there are no other differences like everything what is not correct is `@@@` I can just remove `@@@` from the list. What do you think? If this thing is coming, we know that there are unsupported stuff to show, so remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists