You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/02/03 00:29:22 UTC
Review Request 42982: Defined a virtual `status` method for
Containerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487
Repository: mesos
Description
-------
Defined a virtual `status` method for Containerizer.
Diffs
-----
src/slave/containerizer/containerizer.hpp 08d1ed3cf50f50b5b6e71df60bffbd141490ad32
Diff: https://reviews.apache.org/r/42982/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42982: Defined a virtual `status` method for
Containerizer.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/#review118392
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 8, 2016, 7:19 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42982/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 7:19 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4487
> https://issues.apache.org/jira/browse/MESOS-4487
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Defined a virtual `status` method for Containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 08d1ed3cf50f50b5b6e71df60bffbd141490ad32
>
> Diff: https://reviews.apache.org/r/42982/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42982: Defined a virtual `status` method for
Containerizer.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
-----------------------------------------------------------
(Updated Feb. 8, 2016, 7:19 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487
Repository: mesos
Description
-------
Defined a virtual `status` method for Containerizer.
Diffs (updated)
-----
src/slave/containerizer/containerizer.hpp 08d1ed3cf50f50b5b6e71df60bffbd141490ad32
Diff: https://reviews.apache.org/r/42982/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42982: Defined a virtual `status` method for
Containerizer.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/#review118261
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/containerizer.hpp (line 118)
<https://reviews.apache.org/r/42982/#comment179483>
Put '{' in the next line.
- Jie Yu
On Feb. 5, 2016, 3:35 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42982/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 3:35 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4487
> https://issues.apache.org/jira/browse/MESOS-4487
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Defined a virtual `status` method for Containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 08d1ed3cf50f50b5b6e71df60bffbd141490ad32
>
> Diff: https://reviews.apache.org/r/42982/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 42982: Defined a virtual `status` method for
Containerizer.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 3:35 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487
Repository: mesos
Description
-------
Defined a virtual `status` method for Containerizer.
Diffs
-----
src/slave/containerizer/containerizer.hpp 08d1ed3cf50f50b5b6e71df60bffbd141490ad32
Diff: https://reviews.apache.org/r/42982/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42982: Defined a virtual `status` method for
Containerizer.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 3:35 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487
Repository: mesos
Description
-------
Defined a virtual `status` method for Containerizer.
Diffs (updated)
-----
src/slave/containerizer/containerizer.hpp 08d1ed3cf50f50b5b6e71df60bffbd141490ad32
Diff: https://reviews.apache.org/r/42982/diff/
Testing
-------
make
Thanks,
Avinash sridharan
Re: Review Request 42982: Defined a virtual `status` method for
Containerizer.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
-----------------------------------------------------------
(Updated Feb. 4, 2016, 6:41 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487
Repository: mesos
Description
-------
Defined a virtual `status` method for Containerizer.
Diffs (updated)
-----
src/slave/containerizer/containerizer.hpp 08d1ed3cf50f50b5b6e71df60bffbd141490ad32
Diff: https://reviews.apache.org/r/42982/diff/
Testing
-------
make
Thanks,
Avinash sridharan