You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "W.Alphonse Harouny (JIRA)" <ji...@apache.org> on 2018/09/30 19:20:00 UTC
[jira] [Comment Edited] (MWAR-371) Overlays break first-win rule
for web resource with target path ending with '/'
[ https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633483#comment-16633483 ]
W.Alphonse Harouny edited comment on MWAR-371 at 9/30/18 7:19 PM:
------------------------------------------------------------------
Hello,
The fix is working properly, I attached the expected result to my comment.
An integration test was made as well, have a look at [PathSetTest.java|https://github.com/W-Alphonse/maven-war-plugin/commit/77cbf15e049cf8707a3146470fe407588ff2860b#diff-2cc51c8bb8365c9aa5554e0c9bbfafb5], #testTrimAjdacentSlashes().
was (Author: alf.h):
Hello,
The fix is working properly, I attached the expected result to my comment.
An integration test was made as well, have a look at [PathSetTest.java|https://github.com/W-Alphonse/maven-war-plugin/commit/77cbf15e049cf8707a3146470fe407588ff2860b#diff-2cc51c8bb8365c9aa5554e0c9bbfafb5], #testTrimAjdacentSlashes().
> Overlays break first-win rule for web resource with target path ending with '/'
> -------------------------------------------------------------------------------
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
> Affects Versions: 2.6
> Reporter: Michal Domagala
> Priority: Minor
> Labels: up-for-grabs
> Attachments: custom-0.0.1-SNAPSHOT.war, mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and src/main/custom/a2.txt and settings:
> {code:xml}
> <artifactId>maven-war-plugin</artifactId>
> <configuration>
> <webResources>
> <webResource>
> <directory>src/main/custom</directory>
> <includes><include>a1.txt</include></includes>
> <targetPath>x/</targetPath>
> </webResource>
> <webResource>
> <directory>src/main/custom</directory>
> <includes><include>a2.txt</include></includes>
> <targetPath>x</targetPath>
> </webResource>
> </webResources>
> </configuration>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)