You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/18 09:51:46 UTC
[GitHub] [skywalking-kubernetes] wu-sheng commented on a diff in pull request #96: Refactor oap init job, and support postgresql storage
wu-sheng commented on code in PR #96:
URL: https://github.com/apache/skywalking-kubernetes/pull/96#discussion_r1026230614
##########
chart/skywalking/README.md:
##########
@@ -80,9 +80,9 @@ The following table lists the configurable parameters of the Skywalking chart an
| `ui.service.loadBalancerIP` | Load Balancer IP address | `nil` |
| `ui.service.annotations` | Kubernetes service annotations | `{}` |
| `ui.service.loadBalancerSourceRanges` | Limit load balancer source IPs to list of CIDRs (where available)) | `[]` |
-| `esInit.nodeAffinity` | ES init job node affinity policy | `{}` |
-| `esInit.nodeSelector` | ES init job labels for master pod assignment | `{}` |
-| `esInit.tolerations` | ES init job tolerations | `[]` |
+| `oapInit.nodeAffinity` | OAP init job node affinity policy | `{}` |
+| `oapInit.nodeSelector` | OAP init job labels for master pod assignment | `{}` |
+| `oapInit.tolerations` | OAP init job tolerations | `[]` |
Review Comment:
These look like breaking changes, we should add `breaking change` warning for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org